Can't get onPlayerJoin working

I've read many other topics and "fixed" my code to what they did, however I still can't get it working..
Does anyone see anything wrong with this code? (The rest of the plugin works fine, its just the onplayerjoin that doesn't do anything)

Code:java

package com.cubiceffect.bittiez.rentslots;
 
import java.util.logging.Logger;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.ChatColor;
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.io.OutputStreamWriter;
import java.net.URL;
import java.net.URLConnection;
import java.net.URLEncoder;
import net.milkbowl.vault.economy.Economy;
 
public class rentslots extends JavaPlugin implements Listener {
    Logger log;
    public static Economy economy = null;
    public void onEnable(){
        log = this.getLogger();
        getServer().getPluginManager().registerEvents(this, this);
        if (!setupEconomy() ) {
            log.info(String.format("[%s] - Disabled due to no Vault dependency found!", getDescription().getName()));
            getServer().getPluginManager().disablePlugin(this);
            return;
        }
    }
 
    public void onDisable(){
        log.info("Rent slots disabled.");
    }
 
    private boolean setupEconomy()
    {
        RegisteredServiceProvider<Economy> economyProvider = getServer().getServicesManager().getRegistration(net.milkbowl.vault.economy.Economy.class);
        if (economyProvider != null) {
            economy = economyProvider.getProvider();
        }
 
        return (economy != null);
    }
    @EventHandler(priority = EventPriority.NORMAL)
    public void onPlayerJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        if(player.hasPermission("rentslots.notifyupdate")){
        String updates = senddata("upd", "1", "", ""); //Need to check updates?
        if (updates == "true") {
            player.sendMessage(ChatColor.RED + "[RENT SLOTS] Rent has come commands that need to be ran!");
            player.sendMessage(ChatColor.RED + "[RENT SLOTS] [url]http://cubiceffect.com/shops[/url]");
            player.sendMessage(ChatColor.RED + "[RENT SLOTS] Please click that link and follow the directions!");
        }
        }
 
    }
 
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        if (sender instanceof Player) {
        } else {return false;}
        if (cmd.getName().equalsIgnoreCase("rent")){ // If the player typed /basic then do the following...
            if(!sender.hasPermission("rentslots.rent")) {sender.sendMessage(ChatColor.RED + "You do not have the required permissions"); return true;}
if (args.length > 0) {} else {
    sender.sendMessage(ChatColor.RED + "Avilable commands are:");
    sender.sendMessage(ChatColor.GOLD + "/rent list  <-- A list of all available slots");
    sender.sendMessage(ChatColor.RED + "/rent buy <loc#> <-- Buy a slot(Get the loc# from /rent list");
    sender.sendMessage(ChatColor.GOLD + "/rent price <-- Get the current price of rentals");
    sender.sendMessage(ChatColor.RED + "/rent owned <-- See all currently owned shops");
    sender.sendMessage(ChatColor.GOLD + "/rent pay <loc#> <-- Pay for the next rental period of <loc#>(Get the loc# of your owned shops with /rent owned)");
    return true;
}
String cprice = senddata("gprice", "1", "", ""); //Current price
double bala = economy.getBalance(sender.getName());
int aInt = Integer.parseInt(cprice);
 
if(args[0].equalsIgnoreCase("list")) {
sender.sendMessage(ChatColor.GOLD + senddata(args[0], "checklist", "", ""));
return true;
}
 
if(args[0].equalsIgnoreCase("buy") && args.length > 1) {
    if(bala > aInt){
        String[] gCom = senddata(args[0], sender.getName(), "loc", args[1]).split("////");
if(gCom[0] == "false") {sender.sendMessage(ChatColor.RED + "An error occured"); return true;}
        economy.withdrawPlayer(sender.getName(), aInt);
        String[] dtn = gCom[1].split("<br>");
        for (String s : dtn) {
        sender.sendMessage(ChatColor.GOLD + s);
        }
        return true;
 
    } else {sender.sendMessage(ChatColor.RED + "You do not have enough funds!"); return true;}
}
 
if(args[0].equalsIgnoreCase("price")) {
sender.sendMessage(ChatColor.GOLD + senddata(args[0], "1", "", ""));
return true;
}
 
if(args[0].equalsIgnoreCase("owned")) {
String[] dtn = senddata(args[0], sender.getName(), "", "").split("<br>");
for (String s : dtn) {
    sender.sendMessage(ChatColor.GOLD + s);
}
return true;
}
 
if(args[0].equalsIgnoreCase("pay") && args.length > 1) {
    if(bala > aInt){
        String[] dtn1 = senddata(args[0], args[1], "", "").split("////"); 
 
 
        if(dtn1[0] == "false") {sender.sendMessage(ChatColor.RED + "An error occured"); return true;}
        String[] dtn = dtn1[1].split("<br>");     
 
 
        economy.withdrawPlayer(sender.getName(), aInt);
 
for (String s : dtn) {
    sender.sendMessage(ChatColor.GOLD + s);
}
    } else {sender.sendMessage(ChatColor.RED + "You do not have enough funds!"); return true;}
return true;
}
 
sender.sendMessage(ChatColor.RED + "Avilable commands are:");
sender.sendMessage(ChatColor.GOLD + "/rent list  <-- A list of all available slots");
sender.sendMessage(ChatColor.RED + "/rent buy <loc#> <-- Buy a slot(Get the loc# from /rent list)");
sender.sendMessage(ChatColor.GOLD + "/rent price <-- Get the current price of rentals");
sender.sendMessage(ChatColor.RED + "/rent owned <-- See all currently owned shops");
sender.sendMessage(ChatColor.GOLD + "/rent pay <loc#> <-- Pay for the next rental period of <loc#>(Get the loc# of your owned shops with /rent owned)");
return true;
 
 
        }
 
 
        return false;
    }
 
 
 
 
public String senddata( String param1, String param2, String p3, String p4 )
{
String dta = "";
 
 
            try {
 
            // Construct data
            String data = URLEncoder.encode(param1, "UTF-8") + "=" + URLEncoder.encode(param2, "UTF-8");
            data += "&" + URLEncoder.encode(p3, "UTF-8") + "=" + URLEncoder.encode(p4, "UTF-8");
 
            // Send data
            URL url = new URL("#####Hidden:)#####");
            URLConnection conn = url.openConnection();
            conn.setDoOutput(true);
            OutputStreamWriter wr = new OutputStreamWriter(conn.getOutputStream());
            wr.write(data);
            wr.flush();
 
            // Get the response
            BufferedReader rd = new BufferedReader(new InputStreamReader(conn.getInputStream()));
            String line;
            while ((line = rd.readLine()) != null) {
                dta+= line;
                //System.out.println(line);
            }
            wr.close();
            rd.close();
        } catch (Exception e) {
        }
 
 
 
  return dta;
}
}
 

 

Code:java

 
 if(player.hasPermission("rentslots.notifyupdate")){
 

Could it have to do with the player not having the permission? Possibly try to
comment it out or add a few log statements to see how far it gets before it stops
working?

 

I added a player.sendMessage right before the permission check, it didn't send any message =/

 

Could you instead of using the [ code] brackets in your main post, switch it to
[syntax = java]
code here
[/syntax]
without spaces so I can read it a bit easier?

Do you have the listener initialized properly? I usually use separate classes for my listeners, but I tend to be very object orientated.

I usually do it like this tho:

Code:java

 
SpawnEggThrow EggListener = new SpawnEggThrow(this); //First I tell it that the class SpawnEggThrow will be known as EggListener
 
//Then I punch this out
Bukkit.getServer().getPluginManager().registerEvents(EggListener, this);
//Mind you this is all within the onEnable() method.
 

 

Okay, never mind it's not the onplayerjoin anymore, its something to do with
String updates = senddata("upd", "1", "", ""); //Need to check updates?
if (updates == "true") { <--- is not coming out true for some reason


Ill figure it out, thanks guys!

Hmm, okay so I have tested over and over again, double and triple checked, the string updates is indeed returning "true" any ideas why it seems to think otherwise?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Is it returning a string true or a boolean true?

 

What is the "String updates = senddata " part supposed to do?

Also, its a void, it can't return a boolean true unless you state that a variable is a boolean.

 

It returns a string true, the senddata part posts data to a url and returns whatever the url returned(in this case, "true")

 

try taking that out entirely and see if it works? if it doesn't, then that's not your actuall problem.

//String ~yadayada~

Just noticed, your checking to see if update returns a String with the value of "true"