Very strange: Buckets gets consumed even when event is cancelled?

Here is my code:

Code:java

 
@SuppressWarnings("unchecked")
@EventHandler
public void onPlayerEmptyBucket (PlayerBucketEmptyEvent event) {
ArrayList<String> emptyList = new ArrayList<String>(Arrays.asList(new String[] {}));
emptyList.clear();
Block targetBlock;
boolean walktest;
String chunkOwner;
ArrayList<String> friendsList;
if (!event.isCancelled()) {
Block block = event.getBlockClicked();
BlockFace face = event.getBlockFace();
if (face.equals(BlockFace.UP) || face.equals(BlockFace.DOWN)|| face.equals(BlockFace.SELF)) {
targetBlock = block;
} else {
targetBlock = block.getRelative(face);
}
chunkOwner = getConfig().getString("main.claims." + String.valueOf(targetBlock.getChunk().getX()) + "," + String.valueOf(targetBlock.getChunk().getZ()), null);
if (chunkOwner == null) {
chunkOwner = "";
}
chunkOwner = chunkOwner.toLowerCase();
if (!(chunkOwner.equals(""))) {
walktest = getConfig().getBoolean("main.players." + event.getPlayer().getName().toLowerCase() + ".walktest", false);
if (walktest) {
int bucket = event.getBucket().getId();
event.getPlayer().sendMessage(ChatColor.RED + "[CAC] " + loc_walkteston);
event.getPlayer().sendMessage(ChatColor.RED + "[CAC] " + loc_chunkowner.replaceAll("##X##", String.valueOf(targetBlock.getChunk().getX())).replaceAll("##Y##", String.valueOf(targetBlock.getChunk().getZ())).replaceAll("##N##", chunkOwner.toLowerCase()));
event.getPlayer().sendMessage(ChatColor.RED + "[CAC] " + loc_walktesthelp);
event.setCancelled(true);
event.setItemStack(new ItemStack(bucket,1));
}
else
{
if (!chunkOwner.equalsIgnoreCase(event.getPlayer().getName().toLowerCase())) {
friendsList = new ArrayList<String>((List<String>) getConfig().getList("main.players." + chunkOwner.toLowerCase() + ".friends", emptyList));
if (!friendsList.contains(event.getPlayer().getName().toLowerCase())) {
if (!event.getPlayer().isOp()) {
int bucket = event.getBucket().getId();
event.getPlayer().sendMessage(ChatColor.RED + "[CAC] " + loc_chunkowner.replaceAll("##X##", String.valueOf(targetBlock.getChunk().getX())).replaceAll("##Y##", String.valueOf(targetBlock.getChunk().getZ())).replaceAll("##N##", chunkOwner.toLowerCase()));
event.setCancelled(true);
event.setItemStack(new ItemStack(bucket,1));
}
}
}
}
}
}
}
 
 
@SuppressWarnings("unchecked")
@EventHandler
public void onPlayerFillBucket (PlayerBucketFillEvent event) {
ArrayList<String> emptyList = new ArrayList<String>(Arrays.asList(new String[] {}));
emptyList.clear();
Block targetBlock;
boolean walktest;
String chunkOwner;
ArrayList<String> friendsList;
if (!event.isCancelled()) {
Block block = event.getBlockClicked();
BlockFace face = event.getBlockFace();
if (face.equals(BlockFace.UP) || face.equals(BlockFace.DOWN)|| face.equals(BlockFace.SELF)) {
targetBlock = block;
} else {
targetBlock = block.getRelative(face);
}
chunkOwner = getConfig().getString("main.claims." + String.valueOf(targetBlock.getChunk().getX()) + "," + String.valueOf(targetBlock.getChunk().getZ()), null);
if (chunkOwner == null) {
chunkOwner = "";
}
chunkOwner = chunkOwner.toLowerCase();
if (!(chunkOwner.equals(""))) {
walktest = getConfig().getBoolean("main.players." + event.getPlayer().getName().toLowerCase() + ".walktest", false);
if (walktest) {
event.getPlayer().sendMessage(ChatColor.RED + "[CAC] " + loc_walkteston);
event.getPlayer().sendMessage(ChatColor.RED + "[CAC] " + loc_chunkowner.replaceAll("##X##", String.valueOf(targetBlock.getChunk().getX())).replaceAll("##Y##", String.valueOf(targetBlock.getChunk().getZ())).replaceAll("##N##", chunkOwner.toLowerCase()));
event.getPlayer().sendMessage(ChatColor.RED + "[CAC] " + loc_walktesthelp);
event.setCancelled(true);
event.setItemStack(new ItemStack(325,1));
}
else
{
if (!chunkOwner.equalsIgnoreCase(event.getPlayer().getName().toLowerCase())) {
friendsList = new ArrayList<String>((List<String>) getConfig().getList("main.players." + chunkOwner.toLowerCase() + ".friends", emptyList));
if (!friendsList.contains(event.getPlayer().getName().toLowerCase())) {
if (!event.getPlayer().isOp()) {
event.getPlayer().sendMessage(ChatColor.RED + "[CAC] " + loc_chunkowner.replaceAll("##X##", String.valueOf(targetBlock.getChunk().getX())).replaceAll("##Y##", String.valueOf(targetBlock.getChunk().getZ())).replaceAll("##N##", chunkOwner.toLowerCase()));
event.setCancelled(true);
event.setItemStack(new ItemStack(325,1));
}
}
}
}
}
}
}
 

The problem is that even though I set the itemstack, and cancel the event, the bucket gets emptied. Have also tried with event.getplayer().setiteminhand and omitting setting at all. Wont work.
How can I prevent the bucket from getting consumed?

The strange thing is if player attempts to empty the empty bucket again somewhere, its coming water or lava as usual. Same with fill, the bucket is filled even tought the event is cancelled, and attempting to empty the filled bucket will "cancel" the empty event outside of plugin.

 

I remember running into this problem before. The event is canceled but the client just automatically assumes the event went through. When the player relogs, moves the bucket, attempts to pick or place using the bucket the updated version will be rendered by the client. I remember there being a fix to this by resending what ever was in the clients hand (although it's not an ideal solution). Someone else might be able to answer that part.

 

How I do to resend what its in hand?
SetItemInHand wont work, seems like its executed before event finalization.

Also tried with getScheduler and then putting the SetItemInHand there, but then it complains it can't cast Runnable from a void.

Tried with
event.getPlayer().updateInventory();

but as you see, updateInventory gets a strikethrough and the compiler starts crying about depreciated method.

 

Don't worry, use updateInventory();
There is no good replacement for this method...

I had exactly the same issue with UnlimitedLava. I spent hours to fix it.
This works for me (feel free to use it!)

Code:java

event.setCancelled(true);
ItemStack bucket = new ItemStack(325, 1);
player.setItemInHand(bucket);
player.updateInventory();

 

Yep, updateInventory does work currently, without using setItemInHand.

But wonder, since the method is depreciated, bukkit dev team might remove the method altogheter in the next release?

 

If I recall correctly, they won't remove it in the near future.