[ECON] CommandShops v4.2.0 - The premier local shop plugin. [1.5.2]

Dudes. I need to see what got logged at the time of the problem, and (if applicable) what got logged when the plugin was loaded before showing the problem.

This is similar to what I was planning -- a config option to make owners put chests in the shop to increase the capacity, that way they have to build a more realistically accurate shop and not just bare functional essentials. Now, having the chest interface might be cool but you'd still need to use commands to check the prices so it's not an end-all solution.

What I meant was I don't think plugin threads are moved to Releases anymore

 

How about this:

Player types /buy, is greeted with a opened chest interface.
Player moves the items he wants to his inventory, or what he doesn't to the chest.
When he closes the interface, the chat says: "This will be $$$. Confirm?"
Player types /Confirm when he is satisfied, and if he leaves the store area/disconnects the items are returned.

Another way that it could be done is to send the prices as they pick them up. When they pick up an iron sword they want, the server sends a price message. Its visible through the dark overlay, so its possible to work with.

 

Plugin will not work as register is loading after CommandShops causing it to not be able to find the plugin. RB 1240.

 

hen i use ur plugin when you try to buy somthing it says the max you can buy is 11 for example. then it says error with transaction?

This happens every time you try to buy something around the price of 1544.

 

Fixed (I loaded CommandShops first rather than Register which cause CommandShops to load first by default)

 

How do you set what loads first?

 

Hello. My friend and I seem to be having a bit of trouble with your plugin. We have Register, Icon 6 and your Plugin, but we keep geting​

​

​

Please help, thank you.

 

Howdy,
I'm using Register 1.5 and CommandShops 3.5.3.
The console spits this out when I try to start up my server:

Code:

161 recipes

17 achievements
20:02:55 [INFO] Starting minecraft server version Beta 1.8.1
20:02:55 [INFO] Loading properties
20:02:55 [INFO] Starting Minecraft server on *:25565
20:02:55 [INFO] This server is running Craftbukkit version git-Bukkit-0.0.0-1112-g54a13b2-b1240jnks (MC: 1.8.1)
20:02:55 [SEVERE] Could not load 'plugins\CommandShops.jar' in folder 'plugins': Register
org.bukkit.plugin.UnknownDependencyException: Register
        at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:133)
        at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:215)
        at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:136)
        at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:139)
        at org.bukkit.craftbukkit.CraftServer.<init>(CraftServer.java:104)
        at net.minecraft.server.ServerConfigurationManager.<init>(ServerConfigurationManager.java:52)
        at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:136)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:348)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
20:02:55 [INFO] [Register] Preferred method [null] not found, using first found.

20:02:55 [INFO] [Register] version 1.5 is enabled.
20:02:55 [INFO] Preparing level "Gallifrey"
20:02:55 [INFO] Default game type: 0
20:02:55 [INFO] Preparing start region for level 0 (Seed: 1772835215)
20:02:56 [INFO] Preparing start region for level 1 (Seed: 1772835215)
20:02:56 [INFO] Preparing spawn area: 48%
20:02:56 [INFO] bPermissions is keeping usage stats an. To opt-out for whatever bizarre reason, check plugins/stats.
20:02:56 [INFO] [bPermissions 1.7.3] Using yaml for Permissions
20:02:56 [INFO] [bPermissions] Setting up config for world:Gallifrey
20:02:56 [INFO] [bPermissions] Setup world:Gallifrey
20:02:56 [INFO] [bPermissions] Setup world:Gallifrey_nether
20:02:56 [INFO] [bPermissions] WorldPermissionsManager engaged
20:02:56 [INFO] [bPermissions 1.7.3] Enabled
20:02:57 [INFO] [iConomy - Celty] Enabled (178 ms)
20:02:57 [INFO] Lockette version 1.4.4 is being enabled!  Yay!  (Core version 1.2.3)
20:02:57 [INFO] Lockette: Detected craftbukkit build [1240] ok.
20:02:57 [INFO] Lockette: Linked to Permissions plugin version 2.7.2
20:02:57 [INFO] Lockette: Ready to protect your containers.
20:02:57 [INFO] [MultiInv] version 2.4.1 is enabled!
20:02:57 [INFO] [Multiverse-Core] - Version 2.0-b279 Enabled - By Rigby and fernferret
20:02:57 [INFO] [Multiverse-Core] - Attached to Permissions
20:02:57 [INFO] [AllPay] - Version 3.0 - hooked into iConomy 6 for Multiverse-Core v2.0-b279
20:02:57 [INFO] [Multiverse-Core] - Multiverse Config -- Loaded
20:02:57 [INFO] [Multiverse-Core] - World Config -- Loaded
20:02:57 [INFO] [Multiverse-Core] Loading World & Settings - 'Gallifrey' - NORMAL
20:02:57 [INFO] Preparing start region for level 2 (Seed: 3190306310222784257)
20:02:57 [INFO] [Multiverse-Core] Loading World & Settings - 'world' - NORMAL
20:02:57 [INFO] [Multiverse-Core] Loading World & Settings - 'Gallifrey_nether'- NETHER
20:02:57 [INFO] Preparing start region for level 3 (Seed: 4563313055689548628)
20:02:58 [INFO] [Multiverse-Core] Loading World & Settings - 'world_nether' - NETHER
20:02:58 [INFO] [Multiverse-Core] 4 - World(s) loaded.
20:02:58 [INFO] [MultiVerse-NetherPortals] - Version 2.0-b225 Enabled - By Rigby and fernferret
20:02:58 [INFO] TravelPortals version 1.51 is enabled!
20:02:58 [INFO] [Register] Payment method found (iConomy version: 6)
20:02:58 [INFO] Server permissions file permissions.yml is empty, ignoring it
20:02:58 [INFO] Done (0.312s)! For help, type "help" or "?"
>

Any ideas?

 

Update: I've added this to the main post -- apparently there's a known issue with Register where plugins that use Register in different ways will break each other. Plugins that use Register in the same way will be compatible.
So, everyone having problems related to Register, please make sure of 3 things:

• you have the latest Register version
• Register is in the main plugins folder, not some "lib" folder like a few plugins might tell you to do
• Some other plugin isn't screwing with you

If you have no other plugins loaded aside from (economy, perms, register, CommandShops) and everything's directly in the plugins folder, and you still get issues even when freshly restarting the server, then maybe there's an issue and you should post an updated log.

Thanks everyone for your patience.

 

Hi again,
I removed all but the four plugins you mentioned, made sure they were up-to-date and that they all live in the plugins folder, and it's still giving me this error:

Code:

161 recipes
17 achievements
04:35:41 [INFO] Starting minecraft server version Beta 1.8.1
04:35:41 [INFO] Loading properties
04:35:41 [INFO] Starting Minecraft server on *:25565
04:35:41 [INFO] This server is running Craftbukkit version git-Bukkit-0.0.0-1112-g54a13b2-b1240jnks (MC: 1.8.1)
04:35:41 [SEVERE] Could not load 'plugins\CommandShops.jar' in folder 'plugins': Register
org.bukkit.plugin.UnknownDependencyException: Register
        at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:133)
        at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:215)
        at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:136)
        at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:139)
        at org.bukkit.craftbukkit.CraftServer.<init>(CraftServer.java:104)
        at net.minecraft.server.ServerConfigurationManager.<init>(ServerConfigurationManager.java:52)
        at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:136)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:348)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
04:35:41 [INFO] [Register] Preferred method [null] not found, using first found.

04:35:41 [INFO] [Register] version 1.5 is enabled.
04:35:41 [INFO] Preparing level "Gallifrey"
04:35:41 [INFO] Default game type: 0
04:35:41 [INFO] Preparing start region for level 0 (Seed: 1772835215)
04:35:41 [INFO] Preparing start region for level 1 (Seed: 1772835215)
04:35:42 [INFO] Preparing spawn area: 48%
04:35:42 [INFO] bPermissions is keeping usage stats an. To opt-out for whatever
bizarre reason, check plugins/stats.
04:35:42 [INFO] [bPermissions 1.7.3] Using yaml for Permissions
04:35:42 [INFO] [bPermissions] Setting up config for world:Gallifrey
04:35:42 [INFO] [bPermissions] Setup world:Gallifrey
04:35:42 [INFO] [bPermissions] Setup world:Gallifrey_nether
04:35:42 [INFO] [bPermissions] WorldPermissionsManager engaged
04:35:42 [INFO] [bPermissions 1.7.3] Enabled
04:35:42 [INFO] [iConomy - Celty] Enabled (197 ms)
04:35:42 [INFO] [Register] Payment method found (iConomy version: 6)
04:35:42 [INFO] Server permissions file permissions.yml is empty, ignoring it
04:35:42 [INFO] Done (0.170s)! For help, type "help" or "?"

Thanks for your help

 

Code:

161 recipes
17 achievements
>
14:54:23 [INFO] Starting minecraft server version Beta 1.8.1
>
14:54:23 [WARNING] **** NOT ENOUGH RAM!
>
14:54:23 [WARNING] To start the server with more ram, launch it as "java -Xmx1024M -Xms1024M -jar minecraft_server.jar"
>
14:54:23 [INFO] Loading properties
>
14:54:23 [INFO] Starting Minecraft server on *:7722
>
14:54:23 [INFO] This server is running Craftbukkit version git-Bukkit-0.0.0-1067-g6301507-b1185jnks (MC: 1.8.1)
>
14:54:23 [INFO] While loading Deathpile (plugins/deathpile.jar) found old-data folder: plugins/deathpile next to the new one: plugins/Deathpile
>
14:54:23 [SEVERE] Could not load 'plugins/CommandShops.jar' in folder 'plugins': Register
org.bukkit.plugin.UnknownDependencyException: Register
        at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:133)
        at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:213)
        at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:136)
        at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:138)
        at org.bukkit.craftbukkit.CraftServer.<init>(CraftServer.java:103)
        at net.minecraft.server.ServerConfigurationManager.<init>(ServerConfigurationManager.java:52)
        at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:136)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:348)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
>
14:54:23 [INFO] [Permissions] (Yeti) was initialized.
>
14:54:23 [SEVERE] com.nijikokun.register.payment.Methods.setPreferred(Ljava/lang/String;)Z initializing Register v1.5 (Is it up to date?)
java.lang.NoSuchMethodError: com.nijikokun.register.payment.Methods.setPreferred(Ljava/lang/String;)Z
        at com.nijikokun.register.Register.hasPreferred(Register.java:41)
        at com.nijikokun.register.Register.onLoad(Register.java:55)
        at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:141)
        at org.bukkit.craftbukkit.CraftServer.<init>(CraftServer.java:103)
        at net.minecraft.server.ServerConfigurationManager.<init>(ServerConfigurationManager.java:52)
        at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:136)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:348)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
>

 

There seems to be a bug in Bukkit that ignores hard-dependencies when the depended-on plugin has its own soft-dependencies, but the problem is not reproducable on all servers. You may be able to work around it by renaming Register.jar to ARegister.jar

This guy reported it; he says it's only a problem on Mac but I don't think that's true: http://leaky.bukkit.org/issues/1239

@derJones: it looks like you have bigger problems though, running out of ram and Register itself won't load for whatever reason

 

seems alot of plugins are starting to use other plugins to work togather.
Guess there is no way to just get an update of the local shops that support 1.8 items. without register and such.
Local shops still works fine just no new updated items (of course 1.9 will force an update again)
I keep getting the same issues those above me do (not the out of RAM one)
but register issues.

 

Renaming Register.jar to aRegister.jar did the trick for me. I'm on a pc running windows 7, btw, so doesn't look like it's just a mac problem.

Thanks!

 

Sweet. Please comment on that bukkit bug ticket I linked. It's possible they haven't given it much attention just because they think it's a mac-only issue.

Not exactly. LocalShops 3.1 support for iConomy is outdated and was keeping several servers on an old version, which of course kept them from using plugins that need the newer iConomy. Register is, in theory, a permanent solution to this, even if I disappear.

 

+1 Demand

Would be a nice feature! (however it'd need to be brought up on /buy (& maybe /sell?) command while in the zone -- not by right clicking a chest!)

 

Hey,

i really like this Plugin, but i have one question .
Is it possible to translate the Plugins messages?
Maybe with some kind of a messages.txt in the CommandShops folder.
That would be great .

 

Nothing runs...

15:14:28 [INFO] [CommandShops] Blacki2k2 issued: buy gold 10
15:14:28 [INFO] PlayerFrom: Blacki2k2 balanceFrom: 200000.0 PlayerTo: foxce balanceTo: 30.0 Cost: 11000.0
15:14:28 [INFO] Failed to deposit
15:14:28 [INFO] PlayerFrom: Blacki2k2 balanceFrom: 200000.0 PlayerTo: foxce balanceTo: 30.0 Cost: 199100.0
15:14:28 [INFO] Failed to deposit
15:14:28 [WARNING] [CommandShops] ERROR: Payment failed and could not return funds to original state! Blacki2k2 may need 199,100.00 Goldcoins!

Latest CommandShop + Latest Register + Latest iConomy 6 + Latest Bukkit

 

http://imageshack.us/photo/my-images/822/unledyvg.png/

Does not work.

 

You Could Only Afford 14 Diamond Pickaxe's
Unexpected money Problem: Could not complete sale???

 

I installed all plugins new, but error still exist. Is there anywhere a shop plugin that runs without any problems?


one gold costs 1100...

18:26:24 [INFO] [CommandShops] Blacki2k2 issued: buy gold 1
18:26:24 [INFO] PlayerFrom: Blacki2k2 balanceFrom: 5000.0 PlayerTo: foxce balanceTo: 30.0 Cost: 1100.0
18:26:24 [INFO] Failed to deposit
18:26:24 [INFO] PlayerFrom: Blacki2k2 balanceFrom: 5000.0 PlayerTo: foxce balanceTo: 30.0 Cost: 4400.0
18:26:24 [INFO] Failed to deposit
18:26:24 [WARNING] [CommandShops] ERROR: Payment failed and could not return funds to original state! Blacki2k2 may need 4,400.00 Goldcoins!

 

Seeing this when someone tries to sell >1 item to a shop:

03:04:33 [INFO] [CommandShops] Alviss issued: sell
03:04:33 [INFO] From: Roder000, To: Alviss, Cost: 132.000000
03:04:33 [INFO] PlayerFrom: Roder000 balanceFrom: 2279.25 PlayerTo: Alviss balanceTo: 54.5 Cost: 132.0
03:04:33 [INFO] Failed to deposit
03:04:33 [INFO] PlayerFrom: Roder000 balanceFrom: 2279.25 PlayerTo: Alviss balanceTo: 54.5 Cost: 27348.0
03:04:33 [INFO] Failed to withdraw

Interestingly, the item is priced at 12, 132 is the proper price for what he wanted to sell. The big number cost? It's, wait for it... 2279 of the item, which is the shop seller's current balance. I think there's a variable being improperly assigned somewhere in there.

This just further shows that the Bukkit team has absolutely zero understanding of the GPL which they by their very licensing of their API forced all plugins to license under. Sigh.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

That doesn't help at all. We need the server log when that does happen.

 

And again, but this time 25000 was lost. I'm aware that the user made a bit of a typo here and tried to buy pickaxe diamonds, not a diamond pickaxe, and pickaxe is clearly not a number. Input sanitization, anyone? This command should not have even passed data sanitization.

01:02:11 [INFO] [CommandShops] iplop issued: buy diamond pickaxe 1
01:02:11 [INFO] PlayerFrom: iplop balanceFrom: 26039.67 PlayerTo: Huros balanceTo: 1093.21 Cost: 2500.0
01:02:11 [INFO] Failed to deposit
01:02:11 [INFO] PlayerFrom: iplop balanceFrom: 26039.67 PlayerTo: Huros balanceTo: 1093.21 Cost: 25000.0
01:02:11 [INFO] Failed to deposit
01:02:11 [WARNING] [CommandShops] ERROR: Payment failed and could not return funds to original state! iplop may need 25,000 Plops!
01:02:28 [INFO] [CommandShops] iplop issued: buy diamond pickaxe 1
01:02:28 [INFO] PlayerFrom: iplop balanceFrom: 1039.67 PlayerTo: Huros balanceTo: 1093.21 Cost: 2500.0
01:02:28 [INFO] Failed to withdraw

Again, this time sans typo:

2011-10-13 01:13:18 [INFO] [CommandShops] iplop issued: buy diamondpickaxe 1
2011-10-13 01:13:18 [INFO] PlayerFrom: iplop balanceFrom: 27039.67 PlayerTo: Huros balanceTo: 1093.21 Cost: 2500.0
2011-10-13 01:13:18 [INFO] Failed to deposit
2011-10-13 01:13:19 [INFO] PlayerFrom: iplop balanceFrom: 27039.67 PlayerTo: Huros balanceTo: 1093.21 Cost: 25000.0
2011-10-13 01:13:19 [INFO] Failed to deposit
2011-10-13 01:13:19 [WARNING] [CommandShops] ERROR: Payment failed and could not return funds to original state! iplop may need 25,000 Plops!

One more update, plus the shop file.

Happened to me - took 52500, out of ~54000, for an item with a cost of 2500. Looking through CommandShopBuy.java, the only thing I can think of is something weird with the bundle/amount calculation taking place at L437 or L468. I really don't have the time to step through and debug it right now though.

Shop file exhibiting this behavior:

#CommandShops Config Version 2.0
#Thu Oct 13 01:17:49 EDT 2011
12\:0=0.000000\:1,2.000000\:1,128\:0
14\:0=6.000000\:1,0.000000\:1,0\:0
15\:0=0.000000\:1,10.000000\:1,228\:0
17\:0=0.000000\:1,4.000000\:1,0\:0
20\:0=5.000000\:1,0.000000\:1,54\:0
257\:0=40.000000\:1,0.000000\:1,7\:0
258\:0=40.000000\:1,0.000000\:1,3\:0
261\:0=15.000000\:1,0.000000\:1,1\:0
265\:0=12.000000\:1,0.000000\:1,0\:0
266\:0=6.000000\:1,5.000000\:1,43\:0
267\:0=5.000000\:1,0.000000\:1,4\:0
268\:0=0.000000\:1,0.000000\:1,4\:0
269\:0=6.000000\:1,0.000000\:1,4\:0
278\:0=2500.000000\:1,0.000000\:1,1\:0
292\:0=25.000000\:1,0.000000\:1,4\:0
323\:0=5.000000\:1,0.000000\:1,10\:0
337\:0=0.000000\:1,2.000000\:1,0\:0
345\:0=45.000000\:1,0.000000\:1,3\:0
346\:0=15.000000\:1,0.000000\:1,2\:0
359\:0=25.000000\:1,0.000000\:1,2\:0
45\:0=5.000000\:1,0.000000\:1,8\:0
5\:0=2.000000\:1,0.000000\:1,0\:0
config-version=2.0
creator=Huros
locationA=365, 63, -858
locationB=371, 68, -849
managers=
min-balance=1000.0
name=The Forge
notification=true
owner=Huros
unlimited-money=false
unlimited-stock=false
uuid=624c90b7-0da4-4d2e-a1f8-3157f29ef302
world=world

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Getting same errors.

 

Okay now i updated my server to 1024 ram. but i get this message

Code:

01:24:02 [SEVERE] Could not load 'plugins/CommandShops.jar' in folder 'plugins': Register
org.bukkit.plugin.UnknownDependencyException: Register
        at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:133)
        at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:213)
        at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:136)
        at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:138)
        at org.bukkit.craftbukkit.CraftServer.reload(CraftServer.java:408)
        at org.bukkit.Bukkit.reload(Bukkit.java:173)
        at org.bukkit.command.defaults.ReloadCommand.execute(ReloadCommand.java:22)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:163)
        at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:353)
        at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.java:756)
        at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:721)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:714)
        at net.minecraft.server.Packet3Chat.a(Packet3Chat.java:33)
        at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:92)
        at net.minecraft.server.NetworkListenThread.a(SourceFile:108)
        at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:464)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:374)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
>

 

Update: thanks to the shop file that Thalagyrt posted, I was able to reproduce the problem. I'll have a fix soon.

fyi you're mistaken about what the problem is. "buy diamond pickaxe 1" should actually be a valid command, it's just screwing up in some other way

 

Ah, nice work on the item parsing, then. I didn't have much time to review the source code, so, not surprised I was wrong there, and considering I mentioned in a later post that the same thing happened with diamondpickaxe, well, yeah, pretty much already said I was wrong about that one.

Glad you were able to reproduce it though, and thanks for keeping the plugin alive. It's pretty much the only good local shop plugin around.

 

Alright guys. All the transaction failure issues should be fixed now in 3.5.4.
It was a combination of 2 things: First, when I migrated economy support to Register, I introduced a bug where a payment would fail for insufficient funds if either player didn't have the transaction amount, not just the payer.
Furthermore, there was an existing problem in LocalShops where, if a "buy" failed for any reason, it would assume it was because the buyer didn't have enough money, and would attempt to "reduce" the transaction to the max amount that the buyer could afford.

Error handling in LocalShops was not very robust, and to make matters worse, I sometimes run into copy-pasted comments that are wrong and misleading. I'm improving the code quality with every version though so hopefully I can minimize the amount of time bugs go unfixed.

 

2011/10/15 21:32:34 CEST: Action: sell-item: Player: PureIndianTalent: Shop: King Me!: Item Type: Cobblestone: Number Transfered: 10: Stating Stock: 60883: Ending Stock: 60893: Money Transfered: 0.0: Starting balance: 0.0: Ending balance: 0.0:


Thats in my log, thats telling me nothing is being gained and lost yet in game people still get their money?

@zolcos