[ECON] ChestShop 3.7.18 (iConomyChestShop) - Chest&sign shop for economy plugins [1.8]

Discussion in 'Archived: Plugin Releases' started by Acrobot, Feb 12, 2011.

  1. Offline

    Acrobot

    An easy way to create shops - no protection plugin needed!
    You don't need to be on-line to earn money anymore!
    [​IMG]
    I've put a LOT of effort into making this plugin,
    you can donate if you appreciate my effort =)

    Requirements:
    - An economy plugin supported by Register or Vault, for example iConomy, BOSEconomy or Essentials Eco.
    Optional:
    - For additional economy plugin support - Vault
    - For Permissions: bPermissions, PEX, or any other permission plugin
    - For additional protection: LWC, Lockette, Deadbolt
    - For other item names (aliases): OddItem


    Setup:
    Copy the .jar file from the .zip you downloaded into /plugins folder.
    You can also copy the example files if you want to generate statistics page.

    Translations:
    You can change the plugin's language, here's a list of all user-made translations.
    If you want to update or submit a translation, feel free to PM me.
    Translations (open)

    Arabic - Attarhsase2
    Bulgarian - Muff1Ncho
    Czech - LordPgsa
    Chinese (Simplified) - tab415263
    Danish - Cannafix
    Dutch - speedlegs
    French- DragonSlayer875
    German - RasCas
    Hungarian - Anachen
    Indonesian - Yahya98
    Italian - Massimo1993
    Korean - Zwing87
    Norwegian - _AlexN_ and TheUnkownGamer
    Polish - Holls1
    Portugese (Brasil) - FelipeMarques14
    Russian - VADemon from http://minemania.ru/
    Slovak - LordPgsa
    Slovenian - jEErc
    Spanish - thxaaaa
    Swedish - Maxell
    Turkish - Developer
    Traditional Chinese - hellboyincs
    Vietnamese - etrubi1 from http://minevn.com/


    Permissions:
    How to create a ChestShop?
    - Place a chest, if you haven't already.
    - Place a sign 1 block near the chest (for example, above the chest)
    - On the sign, write:

    [​IMG]
    (Item name can actually be item ID or alias)
    First line will be filled in by the plugin automatically.
    Price is a combination of buy and sell price.
    You have to have B near buy price (people buy from you), and S near sell price (people sell to you).
    If you have both B and S, separate them with a colon - :
    For example:
    [​IMG]

    means that AcrobotPL wants to sell 64 diamonds for 10 currency, and buy them back from you for 5 currency.
    Also, if you put "free" instead of price, it is free to buy or sell :)

    - Now, when you finish editing the sign, if LWC is turned on in config, shop will be automatically created.
    Also, if your default protection is turned on in the config, people won't be able to break chest, sign or the block the sign is on.

    What is an Admin Shop?
    Admin shop is the shop that doesn't require a chest, because it has infinite stock.
    If you sell to it, the items will disappear, and if you buy from it, items will magically appear.
    To create one, you have to be Admin/OP. Just put "Admin Shop" (or anything specified in config file) on the first line of the sign.

    Restricting shops to some groups or regions
    You can either use permissions, or you can just put a sign ABOVE shop sign (you need to be in that group to create the sign) to restrict it to players with ChestShop.group.groupName permission
    The syntax is:
    [restricted]
    firstGroupName
    2ndGroupName
    3rdGroupName
    Only those groups will be able to use that shop

    To restrict a shop to some regions:
    - If you're using Towny, turn TOWNY_INTEGRATION on. Residents will be able to create shops in economy plots (either their or, if specified in config, any)
    - If you're using WorldGuard, you can use an experimental "chestshop" flag. Turn WORLDGUARD_INTEGRATION on and flag a region. (f.e. /region flag ChestShopRegion chestshop allow)

    Do you want to limit the maximum prices for items?
    Well, there's an app.... wait, not that : P
    You can use an experimental feature in ChestShop.
    In your config.yml, add lines like:
    max-buy-price-5: 14
    max-sell-price-5: 15

    That means that the maximum price for items BOUGHT by PLAYER is 14, and items SOLD by PLAYER using the shop is 15.

    You can also use a global setting, like this:
    max-sell-price: 200

    That means that the maximum price for items SOLD to PLAYER is 200 (if there is, for example, a max-sell-price-5 found, it will be used instead of the global sell price)

    USING SHOPS
    You could buy and sell by right and left clicking the sign for a long time.
    Now it's the only way to use the shops.
    It's SIMPLE!
    Just LEFT-CLICK to SELL to shop, and
    RIGHT-CLICK to BUY from shop.
    (This can be changed in the config file)

    DESTROYING SHOPS
    If you want to delete your old shop, simply SNEAK and destroy the sign.
    It's that easy =)

    STOCKING THE SHOPS
    You can either open the chest and stock it up, or click on your own sign - it will open chest's inventory (that way you can have chests not openable by other people for sure :D)

    ItemInfo command
    It's a simple command that shows item information.
    If you use it without any arguments, it shows you information about the item you're holding.
    If you specify item id or item name after the command, it will show you information about that item.

    Source code
    ChestShop is Open-Source =)
    You can find its code on https://github.com/Acrobot/ChestShop-3


    Thanks to:
    - kali876, ziomekYOYO and Herocraft server for testing the plugin and finding every little bug =)
    - Everyone who uses this plugin - really big thanks for this, I never thought it will be so popular
    - Everyone who provided translation - many people's lives will be easier now
    - @Nijikokun for Register
    - @LennardF1989 for awesome Persistence Reimplemented
    - @Temaska for fixing the plugin while I was on holidays
    - @VADemon for providing a great support for other users
    - @Euthyphro for his patience and really good bug spotting
    - vagrant326 for making a great price sheet
    - Epics for his great help
    :)
    If something's not working
    You can't change the sign color - that breaks the formatting.
    If that's not the issue, please give me this information, so I can help you faster.
    - CraftBukkit version (type /version in chat)
    - ChestShop version (type /csversion in chat)
    - Your economy plugin (iConomy? BOSEconomy? other one?)
    - Have you got any Permission plugin? Which one?

    [​IMG]
    Changelog (open)

    Changelog can be found on BukkitDev - http://dev.bukkit.org/server-mods/chestshop/files/
     
  2. Offline

    thomasoo

    i can sell and buy from admin shops but my users can only buy, how do i fix that? i got the permissions right

    ChestShop.shop.*
    Plus
    Theres an exploit in this plugin that will give you lots of Econ cash.
    write on the sign like this
    yournameshop
    1
    S 99999999999
    dirt

    then sell dirt to it for 9999999999
    and no1 loses cash 0.o

    EDIT : they can sell if i op them..
     
  3. Offline

    walsand

    it says i cant make that kind of shop (admin Shop)
    Please reply
     
  4. Offline

    walsand

    thanks Acrobat that helped alot
    I cant creat admin shops it says i cant create that kind of shop
    sorry for all of my confusion, you are a life saver
     
  5. Offline

    Acrobot

    @BHolmes505
    No, you don't.
    Can you download ChestShop 3 again? (Remember the permissions changed!)

    @walsand
    Probably your 3rd sign line is wrong.
    It should be like
    B 5:5 S
    or
    B 5
    or
    S 5 (B and S can be on either side of the price)

    @thomasoo
    That's spawn protection.
    Go to bukkit.yml, change spawn-radius: 0

    @walsand
    Have you got ChestShop.shop.create and ChestShop.admin permissions?
     
  6. Offline

    spunkiie

    @Acrobot

    I've just noticed a HUGE increase in my server load after updating to ChestShop 3.01. I have absolutetly sure that is the new (and only the new) version of your plugin, because after downgrading to 2.x version, my server load decreased 50% (btw: with the SAME number of players) I tested TWICE and both times, 3.01 eat my (linux) server CPU load.

    I have a 600+ server and ppl are happy and used to your great plugin, but, I cannot use the newest version because with it my server can't host more than 400 players (due to the HIGH cpu load). Also, I can't just keep using the old 2.x version because it has item duping bugs (that some of my players are already knowledge).

    So, I'm stuck here. Love your plugin but can't use it anymore. FYI: I'm using LWC integration (BTW: my LWC database has 16kk of protections). Dunno if it has something to do with the problem, but, any advise/test would be welcome.

    TIA.
     
  7. Offline

    walsand

    i got it thanks
    works great
     
  8. Offline

    wicked9090

    ty got it
     
  9. Offline

    Acrobot

    @spunkiie
    Hmm, weird.
    First, try turning LOG_TO_FILE and LOG_TO_DATABASE to false.
    Also, turn GENERATE_STATISTICS_PAGE to false.

    I can try making piston protection optional, because it probably eats most of the resources. (For example, in piston clocks)
     
  10. Offline

    erickingsr

    Need a quick response if possible. Converted from iConomyChestShop 2.x to ChestShop 3.01 and I lost all protections on shops already built.....

    -CB1000
    -LWC 3.3x
    -iConomyChestShop 2.x

    >>>>Want to convert to ChestShop 3.-x<<<<

    Anyone got a solution? Otherwise, just going to keep iConomyChestShop 2.x loaded.

    After further testing - - -

    It appears only 'some' shops had their privatization removed...... Thanks to my Mod/Admin Team.... we ran around to every shop on the server and /cprivate -> /lwc admin forceowner <name> and.... waalah, all shops are now locked properly.

    P.S. Hate it when dumb shit like this happens when updating plugins. I search 50+ pages of this forum thread and NO one else appears to have ever had this problem, fml!
     
  11. Offline

    Acrobot

    @erickingsr
    Wow?
    It shouldn't happen, as it's... well... impossible? Are you sure it wasn't just LWC?
    BTW, I am sorry that you experienced this bug, but AFAIK, you're the only one having it.
     
  12. Offline

    rex41043

    ummmm when i try to take down the sign it opens the dhets befor i can
    can u help me
     
  13. Offline

    Nurgo

    Hi Acrobot, have you any idea when this feature could be implemented ? I'm about to start a new big server and this would be a very important feature, my job system will be entirely based on this.

    I would be happy to donate for this feature :)
     
  14. Offline

    erickingsr

    Acrobot,

    I think this issue lies in 'how you upgrade'

    By dragging the new .jar into your plugins folder and restarting ..... the config file itself is 'updated/changed' and LWC protections are set to false :(

    You should 1)add a link to download the config file and 2) recommend they place BOTH the .jar and config file in the plugins folder before restarting.
     
  15. Offline

    ACallander

    I have guest enabled but they can still buy in the server store. They don't have any commands in there group settings. How do I disable this?
     
  16. Offline

    Siriuo

    You should use essentials user ids for the stores
     
  17. Offline

    thomasoo

    @Acrobot
    What about the money exploit? when will that be fixed?
    type signs like this
    Yournameshop
    1
    S 999999999
    dirt

    =yourname equals your name...lol

    now sell dirt to it for 9999999 and noone loses money..
     
  18. Offline

    AuXDubz

    Hey Remember me :) you helped me on my server. :p
    Just uploaded a Video.. About You Plugin Feel Free to use it Pl0x <33
    haha Peace :D
     
  19. Offline

    Acrobot

    @thomasoo
    Honestly, I believe noone would make a shop for that amount of money, but I'll take a look at it when I'm back home.

    @AuXDubz
    Thanks :)

    @erickingsr
    Are you sure you deleted iConomyChestShop.jar?

    @Nurgo
    Hey - it's already there :) Just look into Permissions section :)

    @rex41043
    Sneak and then destroy the sign.

    @ACallander
    Do you have any permissions plugin?
    If you have GroupManager, you need FakePermissions.
     
  20. Offline

    ACallander

    I'm using bPermissions
     
  21. Offline

    legendx123

    [SEVERE] Could not pass event PLUGIN_ENABLE to ChestShop
    java.lang.NullPointerException
    at com.Acrobot.ChestShop.Listeners.pluginEnable.onPluginEnable(pluginEnable.java:52)
    at org.bukkit.plugin.java.JavaPluginLoader$42.execute(JavaPluginLoader.java:534)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:321)
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:871)
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:264)
    at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:152)
    at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:137)
    at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:284)
    at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:271)
    at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:148)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:335)
    at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)

    That is one of the errors im getting when i start my server up
    Any way to fix it cause I can't do anything it just keeps making errors :/
     
  22. Offline

    Acrobot

    @legendx123
    It is a weird bug, I probably know why it's happening - but I am currently on my laptop, away from home, so I can't fix it.
    You can try running iConomyChestShop until I make the new version.

    @ACallander
    Are you sure you
    - Aren't running 2 permissions plugins?
    - Didn't give those permissions to guests?

    If you didn't do any of those, try negating the permission (IDK about bPermissions, but you could try doing -ChestShop.shop.*)
     
  23. Offline

    Nurgo

    Are you sure?

    In the Permissions section I can see:
    ChestShop.shop.buy.itemID
    ChestShop.shop.sell.itemID

    but not:
    ChestShop.shop.create.buy.itemID
    ChestShop.shop.create.sell.itemID

    What I need is way to prevent certain groups from creating certain types of shop.
    For instance:
    - a lumberjack can create sell-shops for wood, saplings and leaves.
    - a blacksmith can create buy-shops for ore and can create sell-shops for weapons and tools.
    - a baker can create a buy-shop for wheat and a sell-shop for bread.

    Is it possible with the current version? If not, could you please add this feature?
    As I said, I would be happy to make a donation for this feature.

    Also, could you make so that if a permission ChestShop.shop.create.* is removed for a player, he can't continue to earn money with the previously created shops? I think that you could check the permission before each transaction and put the shop out of order if the player don't has the permission anymore.
     
  24. Offline

    Acrobot

    @Nurgo
    There is
    ChestShop.shop.create.itemID

    And for the 2nd, I could do that.
     
  25. Offline

    Nurgo

    Yes, ChestShop.shop.create.itemID is what I'm currently using :)
    But it doesn't differentiate sell-shops and buy-shops. Would it be possible to have more fine-grained permissions.

    Yes can you do that please, I think that it is the behavior that most admins expect.
    Without that, the restriction is somewhat useless because it can be easily circumvented.

    Your plugin is probably the best shop system for Minecraft, I use it since the first versions, but for the new big server that I'm setting up I would like to push it even further and use it as a base for the job system, it's why I need a more advanced permission system.
     
  26. Offline

    GmK

    @Acrobot

    Is there any way to debug the stats.html file never being written to? It is created, but empty.
    What info would you need to help with that?
     
  27. Offline

    Acrobot

    @GmK
    Do you have files in HTML folder?

    @Nurgo
    Okay, I guess I can add that when I'm back home (4 days) :)
     
  28. Offline

    GmK

    Yes, I have the other html files in there. I run a whole webserver, all is good. Only the shopstats.html isnt written to, its empty. The plugin creates it, but doesnt add any data to it.

    Code:
    GENERATE_STATISTICS_PAGE: true
    #If true, plugin will generate shop statistics webpage.
    STATISTICS_PAGE_PATH: "/home/smp/smpweb/shopstats.html"
    #Where should your generated website be saved?
    RECORD_TIME_TO_LIVE: 600
    #How long should transaction information be stored?
    STATISTICS_PAGE_GENERATION_INTERVAL: 60
    Content of the shopstats.html:

    Code:
    
    
    ;)
     
  29. Offline

    Acrobot

    @GmK
    No, I mean, do you have files
    - header.html
    - row.html
    - footer.html
    in plugins/ChestShop/HTML folder?
     
  30. Offline

    GmK

    Ah! lol, I thought they need to be in the same folder as the *resulting* file ;) Thank you! Will test it now

    --Edit--

    The file still remains empty... :(
     
  31. Offline

    Nurgo

    Thank you very much ! :D
     

Share This Page