[ECON] TradeCraft-AE v1.1b - Chest/Gold Based Economy [Permissions] [1337] [BukkitDev]

Discussion in 'Inactive/Unsupported Plugins' started by ArmEagle, Apr 21, 2011.

  1. Offline

    ArmEagle

    Jdwede, Montag, Tonysp and 2 others like this.
  2. Offline

    ArmEagle

    Actually, this is a limitation of the used YAML parser: http://code.google.com/p/snakeyaml/

    From what I understand, the YAML specification says that all parsers are supposed to read special characters. But I guess something is going wrong.

    I stand corrected. It will accept special characters, but your editor has to open/save it using UTF-8 encoding. Though when I use ä in the file, ingame it is shown as another character. Maybe with other encoding it will work.

    But instead you can escape characters in the .lang file, just use \xE4 for ä, etc. Follow this ASCII table and use the hex values http://www.ascii.cl/htmlcodes.htm

    Hmm, maybe I should make the actual commands support localization also. I'll think about that.
     
  3. Offline

    vasil7112

    Could not pass event SIGN_CHANGE to TradeCraft
    java.lang.ClassCastException: org.bukkit.craftbukkit.block.CraftBlockState cannot be cast to org.bukkit.block.Sign
    at nl.armeagle.TradeCraft.TradeCraftBlockListener.onSignChange(TradeCraftBlockListener.java:100)
    at org.bukkit.plugin.java.JavaPluginLoader$31.execute(JavaPluginLoader.java:454)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:310)
    at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:986)
    at net.minecraft.server.Packet130UpdateSign.a(SourceFile:41)
    at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
    at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:75)
    at net.minecraft.server.NetworkListenThread.a(SourceFile:105)
    at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:399)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:309)
    at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)


    Error caused when using Chestshop...
    Plz help..
    Thnx:)

    I will not delete chestshop (New update of iconomychestshop)
    Nether yours..so it would be better to find a way to heelp me:p
     
  4. Offline

    ArmEagle

    I've seen a similar issue before when I used SimpleSignEdit with TradeCraft active and I fixed the issue then.

    I think you are using an old version, since the line your stacktrace mentions does not match my latest code. Please make sure you download the .jar from the top post in this thread again and try again (though you could try and check the server.log to see what version my plugin is reporting on startup - or you could open the TradeCraft.jar you have currently and look in the plugin.yml file).
     
  5. Offline

    vasil7112

    Yea fixed...:p
    Older version..;(
     
  6. Offline

    m0jumb0

    My items are getting clobbered again when withdrawing more than fits in the chest. The bread and other things work correctly, but for some reason cooked porkchops "withdraw" more than 27 into the chest, but the rest get lost.

    this is tradecraft 1.0.5
     
  7. Offline

    ArmEagle

    I've looked into this. I tried a player owned and infinite shops for both pork and grilled pork. And I either cannot buy more than 27 (buy ratio and amount of gold I put in an infinite shop) or I only withdraw the limited 27 items, with the plugin telling me there is more still in the chest.

    At the base of all this is the Bukkit function call Material getMaxStackSize(). That is used to see quickly how much will fit in a chest. But also when putting those items in stacks in the chest. To be honest I thought I had made it an option you could disable, but I can't find that anywhere. Maybe I'm confusing my own plugin with MinecartMania which does have an option to ignore the default stacking.

    But even when something else might have changed the stacksize of items, it *should* also use that same stacksize when actually depositing items in the chest when you withdraw/buy from a shop.

    What version of CraftBukkit are you running. And could you give a step by step example showing when this happens?
     
  8. Offline

    LordAugustus

    Are there any known plugins that tie-in with TC? I'm a long time user, never was a fan of Iconomy or BOSEconomy.
     
  9. Offline

    ArmEagle

    Not that I know. And since the plugin doesn't have any public functions other plugins can call there's a small chance there are any. I never saw the need for any other plugins working on the same idea on our own server either (though I can't really get people to use it that much anyway, we're carebears).

    I've seen a plugin that put cost to repairing tools/armor which could use any item. But you can just as well configure the same there as with TradeCraft separately, or just use another item. Besides that I don't really see the need to demand pay for a whole lot of things anyway.
     
  10. Offline

    DavidPepsi

    I think it would be nice if admins could configure that in TradeCraft.properties
     
  11. Offline

    ArmEagle

    Oh, I actually fixed that so the trade ratio is followed for minimum trade values. There's no reason to expect a 3:1 ratio when the sign reads 6:2. So I don't see a reason why that would be a configurable option.
     
  12. Offline

    khazoids

    Hm, do I have to reinstall tradecraft? because I get an error where my players can't interact with the shops
     
  13. Offline

    ArmEagle

    Did it work before? What version of TradeCraft and Bukkit are you running? What is the error they get? Do you have Permissions setup and if so did you setup the permissions as listed in the first post in this thread?
     
  14. Offline

    khazoids

    IDK what version, I took out the .jar and deleted the ZIP file, but it did work before until today when I used the new build. So idk whats wrong but when I try to right click the sign, it says that me or my players can't interact with the shops
     
  15. Offline

    ArmEagle

    What ZIP file are you talking about? I give a link to the jar of my plugin, no ZIP in sight.

    And to get the version of CraftBukkit, type /version ingame (the version is the number before "jnks"). But you can also check the console or server.log. That will also show the version of my plugin on startup of the server.
     
  16. Offline

    khazoids

    im using 928 craftbukkit but when I downloaded this, it was on the previous craftbukkit. Tradecraft version, AE-1.0.5

    Edit: hm I may of found the problem, I removed permissions 3.1.5b from my folder and all my plugins worked fine, but when I readded it, everything was getting errors again
     
  17. Offline

    ArmEagle

    That would do it. Default no-permissions behavior of TradeCraft lets anyone create player shops and use any type of shop. If something's wrong with Permissions, then those rights can easily be missing.
     
  18. Offline

    khazoids

    So just take permissions out, and have everything running again til a fix?
     
  19. Offline

    ArmEagle

    For my plugin, sure. But can't you roll back to a bit older version? Though I'm still running Permissions 2.7.4 myself.
     
  20. Offline

    khazoids

    I'm using 3.1.5, and 2.7.4 is still compatible with CB928?
     
  21. Offline

    ArmEagle

    I think so. I briefly tried it. Just need to pull a little trick with the plugin.yml file in the Permissions.jar to be able to use the commands. (something startup: load, or so - it's in the RB announcement thread page 2 or so).
     
  22. Offline

    khazoids

    I tried it already and it didn't work
     
  23. Offline

    ArmEagle

    Don't forget that when you go back to using Permissions 2.7.4 you need to use the old style of config files.

    Edit:
    Though the basic permissions seemed to work, just not the commands, iirc.
     
  24. Offline

    michael05242002

    This plugin is simply awesome but i recently find this problem.
    Some players fail to buy something
    Error pop out:
    Code:
    14:28:03 [嚴重的] Could not pass event PLAYER_INTERACT to TradeCraft
    java.util.MissingFormatArgumentException: Format specifier '2$s'
            at java.util.Formatter.format(Unknown Source)
            at java.util.Formatter.format(Unknown Source)
            at java.lang.String.format(Unknown Source)
            at nl.armeagle.TradeCraft.TradeCraft.sendMessage(TradeCraft.java:221)
            at nl.armeagle.TradeCraft.TradeCraftItemShop.playerWantsToBuy(TradeCraft
    ItemShop.java:214)
            at nl.armeagle.TradeCraft.TradeCraftItemShop.handlePatronClick(TradeCraf
    tItemShop.java:177)
            at nl.armeagle.TradeCraft.TradeCraftItemShop.handleRightClick(TradeCraft
    ItemShop.java:17)
            at nl.armeagle.TradeCraft.TradeCraftPlayerListener.onPlayerInteract(Trad
    eCraftPlayerListener.java:32)
            at org.bukkit.plugin.java.JavaPluginLoader$10.execute(JavaPluginLoader.j
    ava:306)
            at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
    a:58)
            at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
    ava:310)
            at org.bukkit.craftbukkit.event.CraftEventFactory.callPlayerInteractEven
    t(CraftEventFactory.java:166)
            at net.minecraft.server.ItemInWorldManager.interact(ItemInWorldManager.j
    ava:212)
            at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:550)
            at net.minecraft.server.Packet15Place.a(SourceFile:57)
            at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
            at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:75)
            at net.minecraft.server.NetworkListenThread.a(SourceFile:105)
            at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:399)
            at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:309)
            at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
    
    I can buy and sell but i don't know why they can't. i hope it helps
     
  25. Offline

    ArmEagle

    Try removing any .lang file in the plugins/TradeCraft folder and restarting the plugin. I think there was an issue with it at some point. Maybe it didn't update (though it tends to update/overwrite too often actually).

    Also, are you sure you are running version 1.0.5 of this plugin?
     
  26. Offline

    michael05242002

    Thx for your quick response.
    I further find that this problem occur if there is 0 item in the box but you still attempt to buy.
    Then you will not receive any response like "the shop does not have enough xxx" but the console receive those errors.
    using #860 and latest version of tradecraft

    Edit:
    One more serious problem occured before
    Players accidentally turn their player shop into infinite shop.
    I don't know how it happen but I see the sign is normal as the other player shops.
    It happened 2 times only though. But the default golden apple the txt is 1:100, so the player generated tons of gold :confused:
    PS. It occur in older verison of plugin. So i don't know whether it will happen again.
     
  27. Offline

    ArmEagle

    Ok, thank you for the extra information in the first part here. I'll look into that specific case.


    I'm not sure about the second part. I might have fixed it in the past, though it's not in the changelog.

    Also aren't apples very hard to obtain (for now)? And, with golden apples taking a red apple and a total of 72 gold ingots to make, it's less than 28 gold ingots 'profit' they make. Unless you of course give away golden apples as a handy healing source, then you should edit the TradeCraft.txt and give them no value.

    Ah indeed, thank you. It was an error on my behalf in the language file. I'll release a new version in a bit. But you can just change the TradeCraft.en.lang file and update the following line (here I already replaced the "%2$" with "%1$"):
    Code:
    CANT_BUY_SHOP_HAS_NO_A_LEFT: "Cannot buy. This shop has no more %1$s left."
    
    Edit:
    .... and then type /tc reload

    Edit2:
    And version 1.0.6 released, which contains that fix.
    Thank you!

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 13, 2016
  28. Offline

    michael05242002

    Pleased to help u:)
    In my server there is a chance to drop apple and very small chance to drop gold apple when leaves decay. So somebody sell his gold apple with 1:1 but accidentally created a infinite shop.
    It is not a major problem if I make all unused item to 0:0 in txt.
     
  29. Offline

    ArmEagle

    As I said. It shouldn't be possible to accidentally create an infinite shop. But if someone still manages to do that, I'd love to hear about how they do it.
     
  30. Offline

    froggy25

    HI

    we just got this plugin on our server today and even tho it is preatty easy to use, nobody can figure out how to set a shop fro stone stairs
    entering name or id doesn't seem to do anything (cbsstairs or 67)
     
  31. Offline

    ArmEagle

    Since you mentioned "cbsstairs", I assume you added that to the TradeCraft.txt list and then either (re)started the server or did a /tc reload ?
    If not, try that, else I can't think of anything right now.
     

Share This Page