Solved Get Command WITHOUT Overriding Other Commands

Xp10d3 · Sep 10, 2020

Basically I'm creating a custom logging system. I want it to be custom and not use other plugins (for a few reasons, one including that I want to learn more about Bukkit API), however I'm confused on how to check if a player sent a command WITHOUT overriding another plugin's command or Bukkit's default commands. So for example, here is the ban command:

Code:java

 
        if (cmd.getName().equalsIgnoreCase("ban") || cmd.getName().equalsIgnoreCase("banip")) {
            if (args.length == 2) {
                Player target = Bukkit.getServer().getPlayer(args[0]);
                //Bukkit.getServer().banIP(target.getUniqueId().toString());
                core.logToCommands("[" + format.format(now) + "]" + "Player " + uuid + " banned " + target.getName() + ". Reason for ban: " + args[2] + ". Logging to ban log...");
                core.banLog("[" + format.format(now) + "]" + "Player " + uuid + " banned " + target.getName() + ". STATS: Experience of player:" + target.getExp() + ". Custom name of player: " + target.getCustomName() + ". Display name: " + target.getDisplayName() + ". First played " + target.getFirstPlayed() + ". Health: " + target.getHealth() + ". Last played " + target.getLastPlayed() + ". Target was online: " + target.isOnline() + ". Reason for ban: " + args[2]);
            } else if (args.length == 1) {
                Player target = Bukkit.getServer().getPlayer(args[0]);
                //Bukkit.getServer().banIP(target.getUniqueId().toString());
                core.logToCommands("[" + format.format(now) + "]" + "Player " + uuid + " banned " + target.getName() + ". Logging to ban log...");
                core.banLog("[" + format.format(now) + "]" + "Player " + uuid + " banned " + target.getName() + ". STATS: Experience of player:" + target.getExp() + ". Custom name of player: " + target.getCustomName() + ". Display name: " + target.getDisplayName() + ". First played " + target.getFirstPlayed() + ". Health: " + target.getHealth() + ". Last played " + target.getLastPlayed() + ". Target was online: " + target.isOnline() + ". There was no reason for the ban.");
            }
        }

Now, everything should work, but I want this to run IN ADDITION to either Bukkit's default /ban command or Essential's /ban command. However, there are many issues.

Code:

1. If I register the command in my constructor OR my main class, it will likely override other plugin's commands.
2. If I DON'T register the command, nothing will happen and it won't log anything.
3. I'm confused how to solve this.
4. I'm not an expert in Java :P

Commands class:

Code:java

 
package eltik.endran.blockres;
 
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.UUID;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class Commands implements CommandExecutor {
 
    Core core = Core.getPlugin(Core.class);
 
    public Commands(Core core) {
        this.core = core;
        //Bukkit.getPluginCommand("eshop").setExecutor(this);
    }
 
    Date now = new Date();
    SimpleDateFormat format = new SimpleDateFormat("dd-MM-yyyy HH:mm:ss");
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String lable, String[] args) {
        if (!(sender instanceof Player)) {
            sender.sendMessage("You must be a player to access this command!");
            core.logToCommands("[" + format.format(now) + "]" + " Something other then a player tried to run a command. Sender was: " + sender);
            return false;
        }
 
        if (sender instanceof Player) {
            core.logToCommands("Player sent command. Command: " + cmd + ". Player: " + sender.getName());
        }
 
        Player player = (Player) sender;
        UUID uuid = player.getUniqueId();
        if (cmd.getName().equalsIgnoreCase("ban") || cmd.getName().equalsIgnoreCase("banip")) {
            if (args.length == 2) {
                Player target = Bukkit.getServer().getPlayer(args[0]);
                //Bukkit.getServer().banIP(target.getUniqueId().toString());
                core.logToCommands("[" + format.format(now) + "]" + "Player " + uuid + " banned " + target.getName() + ". Reason for ban: " + args[2] + ". Logging to ban log...");
                core.banLog("[" + format.format(now) + "]" + "Player " + uuid + " banned " + target.getName() + ". STATS: Experience of player:" + target.getExp() + ". Custom name of player: " + target.getCustomName() + ". Display name: " + target.getDisplayName() + ". First played " + target.getFirstPlayed() + ". Health: " + target.getHealth() + ". Last played " + target.getLastPlayed() + ". Target was online: " + target.isOnline() + ". Reason for ban: " + args[2]);
            } else if (args.length == 1) {
                Player target = Bukkit.getServer().getPlayer(args[0]);
                //Bukkit.getServer().banIP(target.getUniqueId().toString());
                core.logToCommands("[" + format.format(now) + "]" + "Player " + uuid + " banned " + target.getName() + ". Logging to ban log...");
                core.banLog("[" + format.format(now) + "]" + "Player " + uuid + " banned " + target.getName() + ". STATS: Experience of player:" + target.getExp() + ". Custom name of player: " + target.getCustomName() + ". Display name: " + target.getDisplayName() + ". First played " + target.getFirstPlayed() + ". Health: " + target.getHealth() + ". Last played " + target.getLastPlayed() + ". Target was online: " + target.isOnline() + ". There was no reason for the ban.");
            }
        }
 
        if (cmd.getName().equalsIgnoreCase("kick")) {
            if (args.length == 2) {
                Player target = Bukkit.getServer().getPlayer(args[0]);
                core.logToCommands("[" + format.format(now) + "]" + "Player " + uuid + " kicked " + target.getName() + ". Reason for kick: " + args[2] + ". Logging to kick log...");
                core.kickLog("[" + format.format(now) + "]" + "Player " + uuid + " kick " + target.getName() + ". STATS: Experience of player:" + target.getExp() + ". Custom name of player: " + target.getCustomName() + ". Display name: " + target.getDisplayName() + ". First played " + target.getFirstPlayed() + ". Health: " + target.getHealth() + ". Last played " + target.getLastPlayed() + ". Target was online: " + target.isOnline() + ". Reason for kick: " + args[2]);
            } else if (args.length == 1) {
                Player target = Bukkit.getServer().getPlayer(args[0]);
                core.logToCommands("[" + format.format(now) + "]" + "Player " + uuid + " kick " + target.getName() + ". Logging to kick log...");
                core.kickLog("[" + format.format(now) + "]" + "Player " + uuid + " kick " + target.getName() + ". STATS: Experience of player:" + target.getExp() + ". Custom name of player: " + target.getCustomName() + ". Display name: " + target.getDisplayName() + ". First played " + target.getFirstPlayed() + ". Health: " + target.getHealth() + ". Last played " + target.getLastPlayed() + ". Target was online: " + target.isOnline() + ". There was no reason for the kick.");
            }
        }
        return false;
    }
}

You probably don't need this, but my main class:

Code:java

 
package eltik.endran.blockres;
 
import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
import java.io.PrintWriter;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.HashMap;
import java.util.Map;
 
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.util.Vector;
 
public class Core extends JavaPlugin implements Listener {
 
    public void onEnable() {
        this.logToFileGlobal("[" + format.format(now) + "] Block Resistance plugin starting...");
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
        this.logToFileGlobal("[" + format.format(now) + "] Successfully registered commands.");
    }
 
    FileConfiguration config = getConfig();
 
    Date now = new Date();
    SimpleDateFormat format = new SimpleDateFormat("dd-MM-yyyy HH:mm:ss");
 
    public void loadConfig(){
        getConfig().options().copyDefaults(true);
        this.logToFileGlobal("[" + format.format(now) + "] Copied defaults.");
        saveConfig();
        this.logToFileGlobal("[" + format.format(now) + "] Saved config.");
    }
 
    private Map<Block, Integer> blockLives = new HashMap<>();
    @EventHandler
    public void playerTouch(PlayerInteractEvent event){
        Player player = event.getPlayer();
        if (event.getAction().equals(Action.PHYSICAL)){
            Block b = event.getClickedBlock();
            if (!b.getType().equals(Material.STONE_PRESSURE_PLATE)){
                return;
            }
            double y = 2.0;
            Vector vec = new Vector(player.getLocation().getX(), y, player.getLocation().getZ());
            player.setVelocity(vec);
            if (!blockLives.containsKey(b)){
                blockLives.put(b, 10);
                this.logToFileGlobal("[" + format.format(now) + "] Pressure plate was placed. Put 10 lives into it. STATS: Vector = " + vec + ". blockLives hashmap = " + blockLives + ".");
            } else {
                int lives = blockLives.get(b);
                if (lives <= 1){
                    b.setType(Material.AIR);
                    blockLives.remove(b);
                    this.logToFileGlobal("[" + format.format(now) + "] Block didn't have any lives left and was destroyed.");
                    return;
                }
                blockLives.remove(b);
                blockLives.put(b, lives - 1);
                return;
            }
        }
    }
 
    public void logToFileGlobal(String message) {
 
        try {
            File dataFolder = getDataFolder();
 
            if(!dataFolder.exists()) {
                dataFolder.mkdir();
            }
 
            File saveTo = new File(getDataFolder(), "debug.logger");
            if (!saveTo.exists()) {
                saveTo.createNewFile();
            }
 
 
            FileWriter fw = new FileWriter(saveTo, true);
 
            PrintWriter pw = new PrintWriter(fw);
 
            pw.println(message);
 
            pw.flush();
 
            pw.close();
 
        } catch (IOException e) {
 
            e.printStackTrace();
 
        }
 
    }
 
    public void logToListener(String message) {
 
        try {
            File dataFolder = getDataFolder();
 
            if(!dataFolder.exists()) {
                dataFolder.mkdir();
            }
 
            File saveTo = new File(getDataFolder(), "listeners.logger");
            if (!saveTo.exists()) {
                saveTo.createNewFile();
            }
 
 
            FileWriter fw = new FileWriter(saveTo, true);
 
            PrintWriter pw = new PrintWriter(fw);
 
            pw.println(message);
 
            pw.flush();
 
            pw.close();
 
        } catch (IOException e) {
 
            e.printStackTrace();
 
        }
 
    }
 
    public void logToCommands(String message) {
 
        try {
            File dataFolder = getDataFolder();
 
            if(!dataFolder.exists()) {
                dataFolder.mkdir();
            }
 
            File saveTo = new File(getDataFolder(), "commands.logger");
            if (!saveTo.exists()) {
                saveTo.createNewFile();
            }
 
 
            FileWriter fw = new FileWriter(saveTo, true);
 
            PrintWriter pw = new PrintWriter(fw);
 
            pw.println(message);
 
            pw.flush();
 
            pw.close();
 
        } catch (IOException e) {
 
            e.printStackTrace();
 
        }
 
    }
 
    public void banLog(String message) {
 
        try {
            File dataFolder = getDataFolder();
 
            if(!dataFolder.exists()) {
                dataFolder.mkdir();
            }
 
            File saveTo = new File(getDataFolder(), "bans.logger");
            if (!saveTo.exists()) {
                saveTo.createNewFile();
            }
 
 
            FileWriter fw = new FileWriter(saveTo, true);
 
            PrintWriter pw = new PrintWriter(fw);
 
            pw.println(message);
 
            pw.flush();
 
            pw.close();
 
        } catch (IOException e) {
 
            e.printStackTrace();
 
        }
 
    }
 
    public void kickLog(String message) {
 
        try {
            File dataFolder = getDataFolder();
 
            if(!dataFolder.exists()) {
                dataFolder.mkdir();
            }
 
            File saveTo = new File(getDataFolder(), "kicks.logger");
            if (!saveTo.exists()) {
                saveTo.createNewFile();
            }
 
 
            FileWriter fw = new FileWriter(saveTo, true);
 
            PrintWriter pw = new PrintWriter(fw);
 
            pw.println(message);
 
            pw.flush();
 
            pw.close();
 
        } catch (IOException e) {
 
            e.printStackTrace();
 
        }
 
    }
}

Click to expand...

KarimAKL · Sep 10, 2020

@Xp10d3 You're registering a new command. What you want is listening to the PlayerCommandPreprocessEvent.

Xp10d3 · Sep 10, 2020

KarimAKL said: ↑

@Xp10d3 You're registering a new command. What you want is listening to the PlayerCommandPreprocessEvent.
Click to expand...

Thanks! I'll try that. How would I get the second/third argument of the command?
EDIT: Never mind command.split is a thing lol. Marking as solved. Thanks karim

Log in or Sign up

Solved Get Command WITHOUT Overriding Other Commands

Xp10d3

KarimAKL

Xp10d3

Share This Page

Log in or Sign up

Solved Get Command WITHOUT Overriding Other Commands

Xp10d3

KarimAKL

Xp10d3

Share This Page

Useful Searches