Moving Blocks Problem

Hello,

I'm trying to do something like the mini-game Hole In The Wall, and I managed to move an entire wall like shown here:

Moving Wall (open) Moving Wall (close)

But whenever I set couple of blocks to air, like this:

Image (open) Image (close)

and try to move the wall it will just fill all the air blocks and move the wall. What can I do in order to move the wall with the holes?

Another problem I'm facing is whenever I build the wall facing south or north and start moving the wall it'll start moving sideways like this:

Moving Sideways (open) Moving Sideways (close)

 

Okay so whenever I try to start the moving animation I set the holes and then I stored the holes location in a Set<Block>, but when moving the wall to the next new location and and setting the new location to the old holes blocks and it doesn't seem to work.

Code (open) Code (close)

PHP:

private Set<Block> airBlocks = new HashSet<>();

private void start() {
    int minX = plugin.getConfig().getInt("Wall.Min.X");
    int minY = plugin.getConfig().getInt("Wall.Min.Y");
    int minZ = plugin.getConfig().getInt("Wall.Min.Z");
                 
    int maxX = plugin.getConfig().getInt("Wall.Max.X");
    int maxY = plugin.getConfig().getInt("Wall.Max.Y");
    int maxZ = plugin.getConfig().getInt("Wall.Max.Z");
                 
    //..
                 
    for (int i = 0; i < 4; i++) {
        int x = (int) (maxX + Math.round(Math.random() * (minX - maxX)));
        int y = (int) (maxY + Math.round(Math.random() * (minY - maxY)));
        int z = (int) (maxZ + Math.round(Math.random() * (minZ - maxZ)));
        Location airBlock = new Location(player.getWorld(), x, y, z);
        airBlock.getBlock().setType(Material.AIR);
        airBlocks.add(airBlock.getBlock());
    }

    startMovement();       
}

private void startMovement() {
    //..
 
    int minX = min;
    int maxX = max;

    @Override
    public void run() {
        minX++;
        maxX++;
     
        for (int wX = minX; wX <= maxX; wX = wX + 1) {
            for (int wY = minY; wY <= maxY; wY = wY + 1){
                for (int wZ = minZ; wZ <= maxZ; wZ = wZ + 1){
                    Location tmpBlock = new Location(player.getWorld(), wX, wY, wZ);
                    tmpBlock.getBlock().setType(material);
                    for (Block block : airBlocks) {
                        block.getLocation().setX(wX);
                        block.getLocation().setY(wY);
                        block.getLocation().setZ(wZ);
                        block.setType(Material.AIR);
                    }
                }
            }
        }
    }
}

This is just an example of what I did; this problem is so confusing

 

Hmm... Replaced Set<Block> with List<Location> but when setting the holes to the new location it'll set it to the entire wall. The wall just disappears.

PHP:

for (int wX = minX; wX <= maxX; wX = wX + 1) {
    for (int wY = minY; wY <= maxY; wY = wY + 1){
        for (int wZ = minZ; wZ <= maxZ; wZ = wZ + 1){
            Location tmpBlock = new Location(player.getWorld(), wX, wY, wZ);
            tmpBlock.getBlock().setType(Material.ORANGE_TERRACOTTA);
            for (Location location : airBlocks) {
                location.setX(wX);
                location.setY(wY);
                location.setZ(wZ);
                location.getBlock().setType(Material.AIR);
            }
        }
    }
}

 

I know this sounds stupid but can you show me an example?

 

I used the code below to remove the old wall and then set and move the new one, but I can't figure out how to do it with the Pair class, I used your code and nothing moves nor air blocks gets set.

Code (open) Code (close)

Code:

for (int wX = minX; wX <= maxX; wX = wX + 1) {
    for (int wY = minY; wY <= maxY; wY = wY + 1) {
        for (int wZ = minZ; wZ <= maxZ; wZ = wZ + 1) {
            Location tmpBlock = new Location(player.getWorld(), wX, wY, wZ);
            tmpBlock.getBlock().setType(Material.AIR);
        }
    }
}
               
minX++;
maxX++;
               
Material material = Material.ORANGE_TERRACOTTA;
for (int wX = minX; wX <= maxX; wX = wX + 1) {
    for (int wY = minY; wY <= maxY; wY = wY + 1){
        for (int wZ = minZ; wZ <= maxZ; wZ = wZ + 1){
            Location tmpBlock = new Location(player.getWorld(), wX, wY, wZ);
            tmpBlock.getBlock().setType(material);
        }
    }
}

 

The wall just disappears. I've tried debugging the code and everything seems to work fine.

Code (open) Code (close)

PHP:

private List<Pair<Location, Material>> blocks = new ArrayList<>();

private void addBlocks() {
    //..
    BlockVector3 min = sel.getMinimumPoint();
    BlockVector3 max = sel.getMaximumPoint();
   
    blocks.clear();   

    for (int x = min.getBlockX(); x <= max.getBlockX(); x = x + 1) {
        for (int y = min.getBlockY(); y <= max.getBlockY(); y = y + 1) {
            for (int z = min.getBlockZ(); z <= max.getBlockZ(); z = z + 1) {
                Location tmpBlock = new Location(player.getWorld(), x, y, z);
                tmpBlock.getBlock().setType(material);
                blocks.add(new Pair<Location, Material>(tmpBlock, material));
            }
        }
    }

    for (int i = 0; i < 4; i++) {
        int x = (int) (maxX + Math.round(Math.random() * (minX - maxX)));
        int y = (int) (maxY + Math.round(Math.random() * (minY - maxY)));
           int z = (int) (maxZ + Math.round(Math.random() * (minZ - maxZ)));
        Location airBlock = new Location(player.getWorld(), x, y, z);
        airBlock.getBlock().setType(Material.AIR);
        blocks.add(new Pair<Location, Material>(airBlock, Material.AIR));
    }
}

private void start() {
    //..

        int minX = min;
        int maxX = max;

        @Override
        public void run() {
            minX++;
            maxX++;

            for (int wX = minX; wX <= maxX; wX = wX + 1) {
                for (int wY = minY; wY <= maxY; wY = wY + 1){
                    for (int wZ = minZ; wZ <= maxZ; wZ = wZ + 1){
                        for (Pair<Location, Material> block : blocks) {
                            block.getKey().getBlock().setType(Material.AIR);
                            block.getKey().setX(wX);
                            block.getKey().setY(wY);
                            block.getKey().setZ(wZ);
                            block.getKey().getBlock().setType(block.getValue());
                        }
                    }
                }
            }
        }
}

 

Double locations? You mean I should use int instead of double?
The triple loop is used to move the wall to the next new location, in your code you did pair.getKey().add(movementDirection); I’m guessing movementDirection is the new location, and if I add the new location to the pair the wall will stay as it is.

 

Okay thank you I finally got it working, just one question I keep getting NoClassDefFoundError javafx.util.Pair any idea how to fix this error. I followed these steps to install JavaFX.

 

Okay thank you I got it working, any idea on how to set the holes on the wall to another wall but the same location, for example if the holes in the wall are 2 blocks at the top left corner it will set the same thing for another wall top left corner. Take a look at the picture below:

Image (open) Image (close)

 

Sorry to bump this thread I didn't have the time to try this, can you give an example?

 

Why do I need to have 2 lists, could you show me an example code?

 

Okay, I finally got the time to try this. I created a new class called Wall which contains couple of information about the wall, like the list of pairs (List<Pair<Location, Material>>) and a Cuboid class, the issue is that I create a list in my main class which stores all the walls (List<Wall>) and an another list of Integers which I stored 3 random numbers, and then I did this:

Code (open) Code (close)

PHP:

private List<Wall> walls = new ArrayList<>();
private List<Integer> nums = new ArrayList<>();

public void setAirBlocks() {
    nums.clear();
   
    Wall wall = walls.get(0);
    for (int i = 0; i < 3; i++) {
        Random random = new Random();
        int randomItem = random.nextInt(wall.getBlocks().size());
        nums.add(randomItem);
    }

    for (Wall w : walls) {
        for (int num : nums) {
            Pair<Location, Material> pair = w.getBlocks().get(num);
            pair.getKey().getBlock().setType(Material.AIR);
        }
    }
}

If I created 4 walls and I run this function. Only two walls will have the air blocks and the other two will an another air blocks.

 

Here is the problem in game, take a look at the picture below:

Picture (open) Picture (close)

As you can see, two walls have the same holes while the other two have the same holes but different than the previous ones. Any idea why is this happening?