Solved Throw Items?

Hey Guys,
I am trying to spawn a FallingBlock Entity, which works fine. However, I want to remove it after a for loop is done executing.
My code:

Code:java

public class FireTask extends BukkitRunnable {
    private final FallingBlock fire;
    public FireTask(FallingBlock fire) {
        this.fire = fire;
    }
 
    @Override
    public void run() {
        if (fire.isOnGround()) {
            List<Entity> nearby = fire.getNearbyEntities(0.5, 0.5, 0.5);
            for (Entity e : nearby) {
                if (e instanceof Player) {
                    e.setFireTicks(100);
                }
            }
            fire.remove();
        } else {
            cancel();
        }
    }
}

I call the Scheduler in this way:

Code:java

final FallingBlock fire = player.getWorld().spawnFallingBlock(player.getEyeLocation().add(player.getLocation().getDirection().normalize()), Material.FIRE, (byte) 0);
fire.setVelocity(player.getLocation().getDirection().multiply(4));
BukkitTask task = new FireTask(fire).runTaskTimer(this, 0, 1);

The fire entity spawns, but does not get removed. Any help is appreciated!
Thanks,
~StaticJava

 

StaticJava If the falling block is on the ground it will turn into a Block and will no longer be an Entity.

 

So what should I do? Skionz

 

StaticJava I believe you would use the EntityBlockFormEvent.

 

Ah, that makes sense. I will get back to you on whether or not this works.

Ok, so the plugin somewhat works.
Here is my corresponding code:

Code:java

@EventHandler
    public void onItemUse(PlayerInteractEvent event) {
        Player player = event.getPlayer();
 
        if (kitMap.containsKey(player.getUniqueId().toString())) {
            SugarKit kit = kitMap.get(player.getUniqueId().toString());
            if (kit == SugarKit.PYRO) {
                if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK) {
                    if (player.getItemInHand().getType() == Material.DIAMOND_SWORD) {
                        if (player.getItemInHand().getItemMeta().getDisplayName().equals("§c§lPyro's Blade")) {
                            final FallingBlock fire = player.getWorld().spawnFallingBlock(player.getEyeLocation().add(player.getLocation().getDirection().normalize()), Material.FIRE, (byte) 0);
                            fire.setVelocity(player.getLocation().getDirection().multiply(4));
                            BukkitTask task = new FireTask(fire).runTaskTimer(this, 0, 1);
 
                            short durability = player.getItemInHand().getDurability();
                            short maxDurability = Material.DIAMOND_SWORD.getMaxDurability();
 
                            if (durability == maxDurability) {
                                player.getInventory().remove(player.getItemInHand());
                            } else {
                                player.getItemInHand().setDurability((short) (durability + 5));
                            }
                        }
                    }
                }
            }
        }
    }

Here is the FireTask Class:

Code:java

package me.staticjava;
 
import org.bukkit.entity.Entity;
import org.bukkit.entity.FallingBlock;
import org.bukkit.entity.Player;
import org.bukkit.scheduler.BukkitRunnable;
 
import java.util.List;
 
/**
* Created by StaticJava.
*/
public class FireTask extends BukkitRunnable {
    private final FallingBlock fire;
 
    public FireTask(FallingBlock fire) {
        this.fire = fire;
    }
 
    @Override
    public void run() {
        if (!fire.isOnGround()) {
            List<Entity> nearby = fire.getNearbyEntities(0.5, 0.5, 0.5);
            for (Entity e : nearby) {
                if (e instanceof Player) {
                    e.setFireTicks(100);
                    fire.remove();
                }
            }
        } else {
            cancel();
        }
    }
}
 

Here is a video of what is currently happening:
https://www.dropbox.com/s/jwzbh9rqmkk7p2h/Produce_1.mp4?dl=0

As you can see, the flames are somewhat bugged; sometimes they disappear instantly. Additionally, if aimed towards a half block, they drop in the form of a Flame Item (http://jd.bukkit.org/rb/doxygen/dc/dfc/interfaceorg_1_1bukkit_1_1entity_1_1Item.html).
All help is appreciated!
~StaticJava [@Skionz]

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

StaticJava Cancel the ItemSpawnEvent when necessary.

 

Ok, do you know how I can fix the other issues? (Flames disappearing?) Skionz

 

StaticJava Can you elaborate? I can't watch the video right now.

 

Skionz It's kinda hard to explain in words. When are you able to watch the video? I can wait.

Additionally, the fire sometimes turns into a block, even though I cancelled it in the EntityBlockFormEvent. Skionz

Here is an updated video with words to explain the situations: https://www.dropbox.com/s/jwzbh9rqmkk7p2h/Produce_1.mp4?dl=0

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

StaticJava I will watch it in 4 hours. I am at school right now.

 

Ok, thanks.

 

StaticJava Did you use the EntityBlockFormEvent? The code you used above uses a scheduler.

 

Yes:

Code:java

@EventHandler
public void onEntityForm(EntityBlockFormEvent event) {
Block block = event.getBlock();
if (block.getType() == Material.FIRE) {
block.setType(Material.AIR);
}
}

Those events + scheduler cause the video result above. Skionz

 

StaticJava cancel it.

 

Ok, would that fix all of the problems? Skionz

 

StaticJava I'm not sure. Try it.

 

Skionz Ok, the items are no longer spawning on the ground. But the actual fire is still glitched as shown in the video.

 

StaticJava I'm not seeing the issue.

 

Skionz When I throw a flame, it disappears before it reaches an entity.

Video: https://www.dropbox.com/s/jwzbh9rqmkk7p2h/Produce_1.mp4?dl=0 (That is the old version without the EntityFormBlockEvent, but nonetheless, the other issues still apply.)

 

StaticJava I still don't get it. In the video it makes it to the shrub?

 

[quote uid=90861229 name="Skionz" post=2915502]StaticJava I still don't get it. In the video it makes it to the shrub?[/quote]


It should act like this: <Edit by Moderator: Redacted bit url>

Skionz But as you can see, in my video the fire is removed instantly.

 

StaticJava They are using Items in the video, not FallingBlocks.

 

I can help with the cause itself, you don't need to spawn an entity. What do you need done? Something with fire?

 

<Edit by Moderator: Redacted bit url>

I need that. My code is located above Blake

Skionz Ok, I will try using this with Items.

This is my updated event, but the Fire doesn't even spawn o.o Skionz Blake

Code:java

    @EventHandler
    public void onItemUse(PlayerInteractEvent event) {
        Player player = event.getPlayer();
 
        if (kitMap.containsKey(player.getUniqueId().toString())) {
            SugarKit kit = kitMap.get(player.getUniqueId().toString());
            if (kit == SugarKit.PYRO) {
                if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK) {
                    if (player.getItemInHand().getType() == Material.DIAMOND_SWORD) {
                        if (player.getItemInHand().getItemMeta().getDisplayName().equals("§c§lPyro's Blade")) {
                            Item fireItem = player.getWorld().dropItem(player.getLocation(), new ItemStack(Material.FIRE));
                            fireItem.setVelocity(player.getLocation().getDirection().multiply(4));
                            BukkitTask task = new FireTask(fireItem).runTaskTimer(this, 0, 1);
 
                            short durability = player.getItemInHand().getDurability();
                            short maxDurability = Material.DIAMOND_SWORD.getMaxDurability();
 
                            if (durability == maxDurability) {
                                player.getInventory().remove(player.getItemInHand());
                            } else {
                                player.getItemInHand().setDurability((short) (durability + 5));
                            }
                        }
                    }
                }
            }
        }
    }

Here is the updated FireTask:

Code:java

package me.staticjava;
 
import org.bukkit.entity.Entity;
import org.bukkit.entity.Item;
import org.bukkit.entity.Player;
import org.bukkit.scheduler.BukkitRunnable;
 
import java.util.List;
 
/**
* Created by StaticJava.
*/
public class FireTask extends BukkitRunnable {
    private final Item fireItem;
 
    public FireTask(Item fireItem) {
        this.fireItem = fireItem;
    }
 
    @Override
    public void run() {
        if (!fireItem.isOnGround()) {
            List<Entity> nearby = fireItem.getNearbyEntities(0.5, 0.5, 0.5);
            for (Entity e : nearby) {
                if (e instanceof Player) {
                    e.setFireTicks(100);
                    fireItem.remove();
                }
            }
        } else {
            //fireItem.remove();
            cancel();
        }
    }
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

StaticJava Debug.

 

Will try removing/adding things. Not sure what the problem is. :O

EDIT: Can't find the problem. My code is similar to https://forums.bukkit.org/threads/need-help-making-an-object-throw-able.103714/, does anything look abnormal in my code to you which would cause the fire item not spawning? Skionz

 

StaticJava Have you debugged?

 

Skionz Yeah, the event is being called. http://gyazo.com/e96b7568c58997231f16222c8e0a4544 I placed the broadcastMessage statement under all the if-statements, so it reaches the point where I throw Fire.

Additionally, I placed a debug message in my FireTask, and get spammed with this:
http://gyazo.com/e24622a78178c0ba7448de906dd445ca

So both things are being called.

 

StaticJava
The task is being ran a tick later. What happens in that task? You remove the fire item. Boom that's why it's gone in an instant.

 

Gater12 Makes sense. If I remove this, how can I make sure the fire item is removed when it hits the ground, as well as burn all Player entities in its way?

Never mind, fixed this. However, whenever the fire is launched, it always launches far to the left of the player.