Library [1.8] ParticleEffect v1.7

Discussion in 'Resources' started by DarkBladee12, Jun 20, 2013.

Thread Status:
Not open for further replies.
  1. Offline

    Wingzzz

    He said that he went into his options while playing his Minecraft and turned on particles.
     
  2. Offline

    Jaaakee224

    Wingzzz
    I wanted to see what was wrong with my particles, but I figured it out. There is a bug in 1.8 with particles.

    EDIT: I just checked that the next version of 1.8 will fix the bug.
     
  3. Offline

    LCastr0

    What is the bug?
     
  4. Offline

    Jaaakee224

    I noticed that very randomly, a particles that I spawn flashes either really close to the player, or really far. I am not using ParticleEffect v1.5. However, when I do use v1.5, the particles do not spawn at all with no errors of any sort in console.
     
  5. Offline

    DarkBladee12

    Jaaakee224 i'll check this bug, which version of which server software are you currently running?
     
  6. Offline

    Jaaakee224

    DarkBladee12
    Using Spigot, but it happens on Bukkit as well. I noticed this happens on Hypixel, from their Particle Pack.
     
  7. Offline

    worstboy32

  8. Offline

    Jaaakee224

    worstboy32
    I had already stated that this is a bug in 1.8, I checked pre-release version 5 and the bug is gone.

    DarkBladee12
    Maybe you should implement this somewhere in your post that this is a bug in 1.8.
     
  9. Offline

    DarkBladee12

    Jaaakee224 likes this.
  10. Offline

    tr7zw

    Spigot 1.8 doesn't work I think...
     
  11. Offline

    caseif

    DarkBladee12
    Just a heads-up, Mojang changed the constructor for ParticlePlayOutWorldParticles in 1.8. The new constructor is:

    Code:
    PacketPlayOutWorldParticle(EnumParticle, boolean, float, float, float, float, float, float, float, int, int...)
    The EnumParticle is just a basic enum value which can be obtained with EnumParticle.class.getEnumConstants()[effectId]; however, the effect IDs have also changed in 1.8. You can find an updated list in this class.

    I haven't yet figured out what the new boolean flag is for (I've just been passing true). The float values seem to be the same as in 1.7, as does the int. I haven't figured out what the varargs int is for either, but passing a zero-length array seems to have no consequence.

    I hope this makes it a bit easier to update the library to 1.8. Feel free to use any of the code from the repository I linked, but it may be awful because I wrote a fair amount of it at 6 AM after not having slept.
     
  12. Offline

    RingOfStorms

    I think the boolean might be the new distance override, can you see particles from farther away now then when you could?
     
  13. Offline

    ArthurMaker

    RingOfStorms likes this.
  14. Offline

    Olof Larsson

    DarkBladee12 - Are you planning on updating your particle library to support 1.8 as well? I hope you do, it's really awesome :)
     
  15. Offline

    Marten Mooij

    Currently waiting for this as well. :/
     
  16. Offline

    DarkBladee12

    Marten Mooij likes this.
  17. Offline

    Marten Mooij

    I get email notifications when someone replys to this thread, so please do so when you've finished! :D
     
  18. Offline

    DarkBladee12

    ShadyPotato Thanks for your help, I'm currently working on the new version! The varargs are there for the id and data of the block crack, icon crack and block dust effects, because before 1.8 you had to add them to name and now you only pass the id and need an extra parameter for them ;)
     
  19. Offline

    AragurLp

    Can you please make 1.8 Support.
     
  20. Offline

    Jaaakee224

    AragurLp
    He's working on it.
     
    AragurLp likes this.
  21. Offline

    DarkBladee12

    Jaaakee224 The new version is almost finished by now. Should i add compatibility for older Bukkit versions too?
     
  22. Offline

    essem2

    one 1.7 and one 1.8 Version is the best i think
     
  23. Offline

    Olof Larsson

    DarkBladee12 - Yes, compatibility with different server versions is important. Perhaps doing something similar to this is a good idea: https://bitbucket.org/mproncace/par...aft/particlelib/ParticleEffect.java?at=master
    Checking my own plugin (http://mcstats.org/plugin/MassiveCore) it seems the most popular versions at this time are 1.7.10, 1.7.9, 1.8, 1.7.2 and 1.7.5. Meaning most people use either 1.7 or 1.8.
    It would also be awesome if the Spigot 1.8 protocol hack is considered where required. I don't know if there is a requirement to check the protocol version of the player because it can be different? And in the best of worlds both Spigot and CraftBukkit should be supported since both are still actively used.
    Also, since your particle effect library is quite popular, maybe you should put it in a GitHub repository so people can help out with pull requests etc?
    If you do all these things I suggested I will donate 30USD :)
     
    DarkBladee12 likes this.
  24. Offline

    Jaaakee224

  25. Offline

    DarkBladee12

    Jaaakee224 Well I think I'm going to add compatibility for older versions anyways, since I improved how particle effects that require additional data are handled in the methods. Furthermore I added the methods RingOfStorms suggested, which make you able to spawn a particle with a custom direction.
     
    Jaaakee224 and RingOfStorms like this.
  26. Offline

    lme999

    DarkBladee12: Do you have any ETA on when this will have a 1.8 update ready?
     
  27. Offline

    zipzapzopzup

    Hem...
    How can I make it compatible with Cauldron 1.7.2 ? :/
     
  28. Offline

    DarkBladee12

    @lme999 Probably some time today ;)
    @zipzapzopzup Did you test the current version with Cauldron? If it didn't work please post errors so I can help you properly!
     
  29. Offline

    zipzapzopzup

    Hmm, I think I taked the last version.
    I don't remember the exact error (I can't retry right now) but it was a "Your bukkit version is incompatible with this library." and a "net.minecraft.server.1_7_R1.PlayOutWorldParticles" (something like that).
    I'll try to re-download the library.
    Thanks for help !

    EDIT : Didn't work with the latest version.
     
    Last edited: Dec 10, 2014
  30. Offline

    PickNChew

    Can't wait! :D
     
Thread Status:
Not open for further replies.

Share This Page