Trying to activate game in my onEnable method

I am trying to execute my game, meaning give the players all the equitmenet, and tp them to the arena every 280 seconds as specificed in my plugin. The only problem I'm having is defining p, as I am trying to get players from both of my teams, how would I define Player p so the game can get all of the players?

My method:

Code:java

 
public void activateGames(final Player p, int i){
 
    Bukkit.getScheduler().scheduleSyncDelayedTask(DeathMongol.getInstance(), new Runnable(){
            public void run(){
            Random rand = new Random();
                rand.nextInt();
                if (rand.nextInt() % 2 == 0){
                    Hunters.addHunter(p);
                  p.sendMessage(ChatColor.RED + "You are now a hunter");
                }  else if (rand.nextInt() % 3 == 0){
                    Runners.addRunner(p);
                  p.sendMessage(ChatColor.GREEN + "You are now a runner!");
                }
            }       
            },20 * 70);
 
                Arena a = ArenaManager.getManager().getArena(i);
 
 
                p.sendMessage(ChatColor.BLACK + "[DeathCavallo]" + ChatColor.AQUA + "You will be summoned into the arena in 50 seconds..");
                if(Hunters.isPlayerHunting(p) && !Runners.getRunners().isEmpty()){
                    ItemStack[] items = {new ItemStack(Material.COOKED_BEEF, 16), new ItemStack(Material.IRON_SWORD), new ItemStack(Material.BOW)};
                    p.getInventory().addItem(items);
                    p.getInventory().setHelmet( new ItemStack (Material.DIAMOND_HELMET));
                    p.getInventory().setChestplate( new ItemStack (Material.DIAMOND_CHESTPLATE));
                    p.getInventory().setLeggings( new ItemStack (Material.DIAMOND_HELMET));
                    p.getInventory().setBoots( new ItemStack (Material.DIAMOND_BOOTS));
                    p.updateInventory();
                    p.teleport(a.spawn);
                    Horse horse = (Horse) p.getWorld().spawnCreature(p.getLocation(), EntityType.HORSE); // Spawns the horse
                    horse.getInventory().setSaddle(new ItemStack(Material.SADDLE, 1)); // Gives horse saddle
                    horse.setTamed(true); // Sets horse to tamed
                    horse.setOwner(p);// Makes the horse the players
                } else if (Runners.getRunners().isEmpty()){
                    ArenaManager.getManager().removePlayer(p);
                    p.sendMessage(ChatColor.RED + "You've been removed from the game since no players are available");
                    return;
 
            }  if (Runners.isPlayerRunning(p) && !Hunters.getHunters().isEmpty()){
                ItemStack[] items = {new ItemStack(Material.COOKED_BEEF, 16), new ItemStack(Material.DIAMOND_SWORD), new ItemStack(Material.BOW)};
                p.getInventory().addItem(items);
                p.getInventory().setHelmet( new ItemStack (Material.LEATHER_HELMET));
                p.getInventory().setChestplate( new ItemStack (Material.LEATHER_CHESTPLATE));
                p.getInventory().setLeggings( new ItemStack (Material.LEATHER_LEGGINGS));
                p.getInventory().setBoots( new ItemStack (Material.LEATHER_BOOTS));
 
                p.updateInventory();
                p.teleport(a.spawn);
                Bukkit.getScheduler().scheduleSyncDelayedTask(DeathMongol.getInstance(), new Runnable(){
                      public void run(){
                          if(!(Runners.getRunners().isEmpty())){
                              String name = p.getName();
                              Bukkit.getServer().broadcastMessage(ChatColor.BLACK + "[DeathCavallo]" + ChatColor.GOLD + name + ChatColor.AQUA + "Has made it out on time!");
                              ArenaManager.getManager().removePlayer(p);
                          }
                      }
                  }, 20 * 180);
 
 
 
 
            } else if (Hunters.getHunters().isEmpty()){
                ArenaManager.getManager().removePlayer(p);
                p.sendMessage(ChatColor.RED + "You've been removed from the game since no players are available");
                return;

Where it is executed

Code:

public void onEnable(){
       
        instance = this;
        //Listener Registry
        getServer().getPluginManager().registerEvents(new GameListener(), getInstance());
          new ArenaManager(this);
          ArenaManager.getManager().loadGames();
        //Load Config
        if(!getDataFolder().exists())
                getDataFolder().mkdir();
            if(getConfig() == null)
                saveDefaultConfig();
        getLogger().info("Enabling DeathCavallo");
       
       
       
        Bukkit.getScheduler().scheduleSyncRepeatingTask(DeathMongol.getInstance(), new Runnable(){
            public void run(){
Player p = ??
        ArenaManager.getManager().activateGames(p, 1);
            }
    }, 20 * 200, 0); //What does the third number reperesent? The time you wait before it is repeated?
    

My hunter class (Runner class pretty much the same):

Code:java

package me.creeoer.teams;
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
 
public class Hunters {
 
 
 
 
private static List<UUID> hunters = new ArrayList<UUID>();
 
    public static  void addHunter(Player player){
        if(hunters.contains(player)){
            return;
        }
        hunters.add(player.getUniqueId());
        player.setDisplayName(ChatColor.RED + player.getName());
 
 
        }
    public static List<UUID> getHunters(){
        return hunters;
    }
    public void removeHunter(Player player){
        if(hunters.contains(player)){
            hunters.remove(player);
        }
    }
 
    public static boolean isPlayerHunting(Player player){
        if (hunters.contains(player)){
            return true;
        } else
            return false;
    }
 
 
    }
 

 

Is there any specific place we should be looking? It would help if you had a stack trace or something.

 

Creeoer

• Why are you using nextInt() and % 2, just use nextInt(2)
• No need for using static plugin instances
• saveDefaultConfig() already checks for the existance of a config.yml file. That aside, the null check is completely unrelated to the default config.
• No need for enable/disable messages, there's a thing called Bukkit doing that for you
• A static List... please stay away from static until you properly know the impacts. Even if we leave that aside, it's bad design to use static.
• The third parameter in a timer task is the interval (indeed, the time between task #n and task #n+1)

 

Code:java

 public static boolean isPlayerHunting(Player player){
        if (hunters.contains(player)){
            return true;
        } else
            return false;
    }

just do

Code:

public static boolean isPlayerHunting(Player player){
  return hunters.contains(player);
}

 

inb4 List<UUID>

 

Creeoer

Code:java

}, 20 * 200, 0); 

First long represents how many ticks before starting the runnable.
Second long represents how many ticks before rerunning the runnable.
For instance, if I did 20, 10 and ran it onEnable, it would wait 1 second before running the runnable then run it half a second repetitively thereafter.

The fact you did 0, I think you meant to do

Code:java

}, 20 * 200, 20 * 200); 

 

fireblast709 oh my good catches! Yet another like for you!

 

stormneo7 fireblast709 Thank you for the lesson on static, I've created instnaces of both of my classes . And I appreciate all of your help,but I still don't know what to define player as in my onEnable? I just started java itself 3 weeks ago, I hope I'm not missing sometihng here.

 

Creeoer why would you need to access a player on onEnable?

 

Necrodoom so I can give a player object to my activateGame method to allow it to execute, I need to define what player is.

 

Creeoer you won't have any player object on onEnable. Don't you need to wait for a certain amount of players to start a game?

 

Necrodoom No, I just need 1 player on the hunter team and 1 player on the runner. I made a method to tp all the players from both of those teams into the arena spawn, and I want to start the game every 200 seconds inside my onEnable method. My method needs a player object isnce it is a paramater in my method, I just need to define that player object so I can get my players from both teams

 

Creeoer again, you won't have 2 players on onEnable, the server just started.
Your activeGames currently only sets up a single player - can you paste the entire project please? Preferably using github - I don't think you are understanding what you are trying to do.

 

Necrodoom Alrigth, I'll edit this post with a link once I have one, btw you I've noticed you always are offline, but you still manage to reply..

 

Creeoer my online status is hidden, to reduce random PMs.

 

Necrodoom Here, first time using github btw, followed a tutorial : https://github.com/Creeoer/DeathCavallo Hm, my activate game method isn't there, it didnt quite work anyway.