Multiple Commands?

Hey!
I was just wondering why this won't work?
IT seems simple, but i just can't work out why?
Only /heal works, and gives the user in console. However none of the other code works

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        Player player = (Player) sender;
 
        if (cmd.getName().equalsIgnoreCase("Heal")) {
            if (args.length == 0) {
                if (sender instanceof Player){
                player.setHealth(20);
                String someone = player.getName();
                player.sendMessage(ChatColor.RED + "[Shields+] "
                        + ChatColor.GREEN + "You have been healed!");
                getLogger().warning(someone + " Healed Themselve!");
                return false;
                }
                if (args.length == 1) {
                    player.sendMessage(ChatColor.RED + "[Shields+]"
                            + ChatColor.DARK_RED
                            + " /heal does not require any further args");
                    return false;
                }
 
                    if (cmd.getName().equalsIgnoreCase("Feed")) {
                        if (args.length == 0) {
                            player.setFoodLevel(20);
                            player.sendMessage(ChatColor.RED + "Shields+] "
                                    + ChatColor.GREEN + "You have been fed!");
                            player.addPotionEffect(new PotionEffect(
                                    PotionEffectType.HEAL, Integer.MAX_VALUE, 0));
                        return true;
                        }
                    }
                }
                {
                }
            }
        return true;
        }{
    }{
}
}

 

you have your feed command inside your heal command

Code:java

 
if (cmd.getName().equalsIgnoreCase("Heal")) {
    if (cmd.getName().equalsIgnoreCase("Feed")) { //this will never be true
 
    }
}

 

After your heal command add an 'else if' statement and add your feed command there.

 

ProMCKingz Along with Gamesareme said, use if, else if, statements rather then multiple if statements it's more efficient and looks cleaner. Why have the program check for 3 arguments when you already decided that it has two arguments

Another suggestion, if you are planning on outputting text to the user with the plugin tag in front of it, I would recommend creating a MessageFormatter class that contains a method that takes in the message and automatically formats it for you. That way your not constantly adding that tag every time you have to send the message.

Along with my other to suggestions, I don't see why you are blindly casting the sender to a Player, then checking if it's an instance of a player later on. Your also going to want to add an else statement after you check the sender so that the Console knows if you can't use that command without being logged in.

Although after reading what these guys said and it works, I would highly suggest to review your code and make it as efficient as possible, because after all that's what makes plugins get to the top of the list. There is more to programming then getting it to work.

Best of luck coding

 

jthort
Thanks for you help, and finding other mistakes!
I am still new to coding and have found these forums very useful and productive.
Thanks for your time! (editing 6 times)

I have done the following, and everything else works, except the feed command.

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        Player player = (Player) sender;
 
        if (cmd.getName().equalsIgnoreCase("Heal")) {
            if (args.length == 0) {
                if (sender instanceof Player){
                player.setHealth(20);
                String someone = player.getName();
                player.sendMessage(ChatColor.RED + "[Shields+] "
                        + ChatColor.GREEN + "You have been healed!");
                getLogger().warning(someone + " Healed Themselve!");
                }else{
                    getLogger().warning("You cannot perform this command from console!");
                return false;
                }}
                else if (args.length == 1) {
                    player.sendMessage(ChatColor.RED + "[Shields+]"
                            + ChatColor.DARK_RED
                            + " /heal does not require any further args");
                    return false;
                }else{
 
    if (cmd.getName().equalsIgnoreCase("Feed")) {
                        if (args.length == 0) {
                            player.setFoodLevel(20);
                            player.sendMessage(ChatColor.RED + "[Shields+] "
                                    + ChatColor.GREEN + "You have been fed!");
                            player.addPotionEffect(new PotionEffect(
                                    PotionEffectType.HEAL, Integer.MAX_VALUE, 0));
                        return true;
                        }
                    }
                }
                {       
                }{
                }}
        return false;}}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ProMCKingz

You're still checking if the command is "Feed" within the scope of the "Heal" conditional check. Line 24 will always be false.

As well as this, what's with the bracket spam on lines 35-37?

 

Low quality ASCII art?

 

Dragonphase
How do I change it then?

 

ProMCKingz

Check for the Feed command outside of the check for the Heal command.

 

Dragonphase
How?

 

ProMCKingz This is pretty basic Java syntax. http://docs.oracle.com/javase/tutorial/java/nutsandbolts/if.html

 

Essentially with if statements you always need to close them off if you want to have another if that's not nested.
So like:

Code:java

if (cmd.getName().equalsIgnoreCase("Heal")) {
//heal stuff
}
if (cmd.getName().equalsIgnoreCase("Feed")) {
//feed stuff
}

Simple java syntax stuff that you should learn.

 

So this?

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        Player player = (Player) sender;
 
        if (cmd.getName().equalsIgnoreCase("Heal")) {
            if (args.length == 0) {
                if (sender instanceof Player){
                player.setHealth(20);
                String someone = player.getName();
                player.sendMessage(ChatColor.RED + "[Shields+] "
                        + ChatColor.GREEN + "You have been healed!");
                getLogger().warning(someone + " Healed Themselve!");
                }else{
                    getLogger().warning("You cannot perform this command from console!");
 
                }}
                else if (args.length == 1) {
                    player.sendMessage(ChatColor.RED + "[Shields+]"
                            + ChatColor.DARK_RED
                            + " /heal does not require any further args");
 
                }
 
    if (cmd.getName().equalsIgnoreCase("Feed")) {
                        if (args.length == 0) {
                            player.setFoodLevel(20);
                            player.sendMessage(ChatColor.RED + "[Shields+] "
                                    + ChatColor.GREEN + "You have been fed!");
                            player.addPotionEffect(new PotionEffect(
                                    PotionEffectType.HEAL, Integer.MAX_VALUE, 0));
                        return true;
                        }
    }
        }
        return false;
    }}
 

 

ProMCKingz

No... your Feed check is still inside the Heal check... Please read AdamQpzm 's post on Java Syntax.

 

Dragonphase
I have read it.
However I still don't see what I am making an error on.
Is it the "}" or what?
Please help!
I know this is basic, however i'm just confused!

 

ProMCKingz The reason you're confused is because you don't understand the basics of Java: You need to learn these basics - which takes time, effort, and patience - otherwise you will encounter problems all the time and have no idea how to fix them. For this problem, I'll tell you that the check for feed needs to come after the check for heal is closed, and statements are opened and closed with { and }...

Either way, you'll still need to learn Java before playing around with Bukkit plugins.

 

ProMCKingz

This is what your code looks like formatted:

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label,
String[] args) {
    Player player = (Player) sender;
 
    if (cmd.getName().equalsIgnoreCase("Heal")) {
        if (args.length == 0) {
            if (sender instanceof Player){
                player.setHealth(20);
                String someone = player.getName();
                player.sendMessage(ChatColor.RED + "[Shields+] "
                + ChatColor.GREEN + "You have been healed!");
                getLogger().warning(someone + " Healed Themselve!");
                }else{
                getLogger().warning("You cannot perform this command from console!");
 
            }
        }
        else if (args.length == 1) {
            player.sendMessage(ChatColor.RED + "[Shields+]"
            + ChatColor.DARK_RED
            + " /heal does not require any further args");
 
        }
 
        if (cmd.getName().equalsIgnoreCase("Feed")) {
            if (args.length == 0) {
                player.setFoodLevel(20);
                player.sendMessage(ChatColor.RED + "[Shields+] "
                + ChatColor.GREEN + "You have been fed!");
                player.addPotionEffect(new PotionEffect(
                PotionEffectType.HEAL, Integer.MAX_VALUE, 0));
                return true;
            }
        }
    }
    return false;
}
}

Your conditional statement for the Feed command is still within the conditional statement for the Heal command. Cut the entire section out for the Feed command, and paste it outside the next bracket. You also have too many closing brackets, so remove the bracket from the last line.