Odd Item Glitch.

Ok.
In my plugin, there's a GUI which gives the user a kit. The kit contains a Diamond Sword and the rest of the inventory full of soup. However, only the soup that lands on the hotbar actually works. (Fast Soup Plugin: http://dev.bukkit.org/bukkit-plugins/beastsoup/). We know it's not the soup plugin, as we tested with different soup plugins. Also, the soup problem only occurs when you receive the kit from the GUI.

Code:

Code:java

package me.kitpvp.GUI;
 
import java.util.ArrayList;
import java.util.List;
 
import me.kitpvp.SonicKit.Main;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.potion.PotionEffect;
 
public class PvPGUI implements Listener {
 
    private Main plugin;
    public PvPGUI(Main plugin) {
    this.plugin = plugin;
    }
 
    List<String> apvp = new ArrayList<String>();
 
 
    @EventHandler
    public void onGUISelect(InventoryClickEvent e) {
        Player p = (Player) e.getWhoClicked();
        if(e.isLeftClick()){
 
            if(e.getCurrentItem().getItemMeta().getDisplayName().equals(ChatColor.GREEN + "PvP")){
 
 
            if(e.getCurrentItem().getType().equals(Material.DIAMOND_SWORD)){
 
                Inventory inv = p.getInventory();       
                if(plugin.kit.contains(p.getName())) {
                    p.sendMessage(ChatColor.RED + "You can only use one kit per life!");
                } else {
 
                plugin.kit.add(p.getName());
                inv.clear();
                //Remove Potion Effects
                for (PotionEffect effect : p.getActivePotionEffects())
                    p.removePotionEffect(effect.getType());
 
                // Send the player a message
                String pvp = plugin.getConfig().getString("pvpmsg");
    String prefixmsg = plugin.getConfig().getString("prefixmsg");
 
                p.sendMessage(ChatColor.GOLD + "[" + ChatColor.RED + "" + prefixmsg + ChatColor.GOLD + "] " + ChatColor.GOLD + " " + pvp);
 
                // List Items
                ItemStack sword = new ItemStack(Material.DIAMOND_SWORD);
 
 
 
                // List armor
                ItemStack helm = new ItemStack(Material.IRON_HELMET);
                ItemStack chest = new ItemStack(Material.IRON_CHESTPLATE);
                ItemStack legs = new ItemStack(Material.IRON_LEGGINGS);
                ItemStack boots = new ItemStack(Material.IRON_BOOTS);
 
                // Enchant any items
                sword.addEnchantment(Enchantment.DAMAGE_ALL, 1);
 
                // Add any potion effects
 
                // Add items to inventory (weapons first.)
                inv.addItem(sword);
 
            // List & add Soup (Make the "<=35>" less if you have more than 1 item)
 
                        ItemStack getSoup = new ItemStack(Material.MUSHROOM_SOUP, 1);           
                        for(int i=1; i <=35; i++)
                            inv.addItem(getSoup);
                        p.getOpenInventory().close();
 
 
 
                //Put armor on player
                ((PlayerInventory) inv).setHelmet(helm);
                ((PlayerInventory)inv).setChestplate(chest);
                ((PlayerInventory)inv).setLeggings(legs);
                ((PlayerInventory)inv).setBoots(boots);
 
                p.updateInventory();
 
 
            }
 
        }               
    }
    }
    }
}

Anyone have any ideas?

Anyone got any advice?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

HyrulesLegend Try to update the users inventory after

 

Updated the code, still doesn't work. I'm not sure why it does this, It's as the soup is not actually there, cause when I hit the ground with the soup in hand, it goes away.

 

@HyrulesLegend Also can you put your code in Java format so I can read it easier xD

@HyrulesLegend So when you click on the item in the inventory it will close the inventory and give you the sword and soups, but when a user is killed it only drops the items that are in his hotbar?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It's because you're looping too many times. You're trying to add soup when there is no space and so it glitches for some odd reason. Loop with the other item(s) in mind.

 

JBoss925 I can't believe I missed that >.<

 

Lol it's all good. I've missed worse. Like stack traces xP

 

JBoss925 PurePlugins
Not sure what you're saying, what's wrong with the loop?
EDIT: I just tested with my anti death drop off.. all the soup dropped from his inventory..
EDIT #2 (xD): That exact loop and the soup in the kit works perfectly fine in all my other kits, just not anything in the GUI.

 

@HyrulesLegend Ok so with your loop, you are looping over all 35 slots in the inventory right? but you aren't taking into account the items that the user may have on him

 

Inventory is cleared before hand.

 

HyrulesLegend this will return the number of empty slots in the players inv, this is what you want to loop over :3

Code:java

public int getEmptySlots(Inventory inventory) {
  int i = 0;
  for (ItemStack is : inventory.getContents()) {
  if (is == null)
    continue;
  i++;
  }
  return i;
}

 

Problem Solved! I created a separate method to give me the items and it worked.