Help with signs and enchants

Code:java

package drpk;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.block.Sign;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class AddFortune1 extends JavaPlugin implements Listener {
 
 
@EventHandler
public void onSignChange(SignChangeEvent e) {
if (e.getLine(0).equalsIgnoreCase("[etoken]"))
if (e.getLine(1).equalsIgnoreCase("[Fortune1]"))
e.setLine(0, "&3[etoken]");
e.setLine(1, "&3[Fortune1]");
e.setLine(2, "&3Click here with 2 etokens!");
e.setLine(3, "&3to get an extra level of fortune!");
}
 
 
@EventHandler
 
public void onPlayerInteract(PlayerInteractEvent evt) {
if (evt.getPlayer().getInventory().getType().equals(Material.RECORD_12));
 
//do whatever
 
// code
{
//makes sure it's an event
if (evt.getAction() != Action.RIGHT_CLICK_BLOCK)
if (evt.getClickedBlock().getState() instanceof Sign) {
//if player right clicks sign with the set lines
Sign s = (Sign) evt.getClickedBlock().getState();
if (s.getLine(1).equalsIgnoreCase("[eTokens]")) {
if(evt.getPlayer().getItemInHand().getType().equals(Material.DIAMOND_PICKAXE));{
if(evt.getPlayer().getItemInHand().getType().equals(Material.GOLD_PICKAXE)); {
if(evt.getPlayer().getItemInHand().getType().equals(Material.IRON_PICKAXE)); {
if(evt.getPlayer().getItemInHand().getType().equals(Material.STONE_PICKAXE)); {
if(evt.getPlayer().getItemInHand().getType().equals(Material.WOOD_PICKAXE)); {
ItemStack item = evt.getPlayer().getItemInHand();
evt.getPlayer().getInventory().removeItem(new ItemStack(Material.RECORD_12, 2));
if (item != null) { // So you don't get errors in the console about NullErrorException
if (item.containsEnchantment(Enchantment.LOOT_BONUS_BLOCKS)) { // check if item in hand has fortune enchantment
item.addEnchantment(Enchantment.LOOT_BONUS_BLOCKS, item.getEnchantmentLevel(Enchantment.LOOT_BONUS_BLOCKS) + 1); // Add the same enchantment but with level increase of +1
 
}
 
}
}
}
}
 
 
}
}
}
}
//they get healed
evt.getPlayer().sendMessage(ChatColor.GREEN + "Your tool has 1 more level of fortune!");
//message sent when healed
}
}
}
 
 

the signs wont make or enchant, I'm using Bukkit-1.7.2-R0.2
there's also nothing in console that would suggest it wouldn't work.

 

drpk
Use proper package naming conventions please.

Also register your events.

http://wiki.bukkit.org/Event_API_Reference
http://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html

 

Also for the sign change event do this:

Code:java

if (e.getLine(0).equalsIgnoreCase("[etoken]") && (e.getLine(1).equalsIgnoreCase("[Fortune1]")){
// What you're changing the signs into
}
 
 

It might not help but it will make it a little cleaner! Plus when you're getting the sign in the interact you have to get the color too or at least strip it of its color. Another problem is that you are getting the wrong line in the clicked block even line 1 is your fortune line not your [eToken] line which is line 0

 

Don't be lazy; always use brackets, especially if you're a beginner.

 

The only time brackets are not necessary is when there is only one line of code after it.

 

It's best not to omit them at all; the little time you save by doing so is made worthless when you run into unexpected logical errors. In general, especially for a beginner, it's best to always use brackets.

 

Still wont work :/

 

bump

 

drpk What "doesn't work" about it? Post explanation of how it "doesn't work" and the code you have.

 

here's my code

Code:java

package com.drpk;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.block.Sign;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
 
 
public class AddFortune1 implements Listener {
 
 
        @EventHandler
        public void onSignChange(SignChangeEvent e) {
                if (e.getLine(0).equalsIgnoreCase("[etoken]"))
                  if    (e.getLine(1).equalsIgnoreCase("[Fortune1]"))
                        e.setLine(0, "§3[etoken]");
                        e.setLine(1, "§3[Fortune1]");
                        e.setLine(2, "§3Click here with 2 etokens!");
                        e.setLine(3, "§3to get an extra level of fortune!");
                }
 
 
        @EventHandler
 
        public void onPlayerInteract(PlayerInteractEvent evt) {
      if (evt.getPlayer().getInventory().getType().equals(Material.RECORD_12));
 
            //do whatever
 
            // code
            {
            //makes sure it's an event     
                if (!(evt.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
                if (evt.getClickedBlock().getState() instanceof Sign) {
                    //if player right clicks sign with the set lines
                        Sign s = (Sign) evt.getClickedBlock().getState();
                        if (s.getLine(1).equalsIgnoreCase("§3[Fortune1]")) {
                            if (evt.getPlayer().getItemInHand().getType().equals(Material.DIAMOND_PICKAXE));{
                            if (evt.getPlayer().getItemInHand().getType().equals(Material.GOLD_PICKAXE));  {
                            if (evt.getPlayer().getItemInHand().getType().equals(Material.IRON_PICKAXE));  {
                            if (evt.getPlayer().getItemInHand().getType().equals(Material.STONE_PICKAXE));  {
                            if (evt.getPlayer().getItemInHand().getType().equals(Material.WOOD_PICKAXE)); {
 
                            }
 
                            }
                            }
                            }
                            }
 
                                ItemStack item = evt.getPlayer().getItemInHand();
                                if (item != null) { // So you don't get errors in the console about NullErrorException
                                    if (item.containsEnchantment(Enchantment.LOOT_BONUS_BLOCKS)) { // check if item in hand has fortune enchantment
                                        item.addEnchantment(Enchantment.LOOT_BONUS_BLOCKS, item.getEnchantmentLevel(Enchantment.LOOT_BONUS_BLOCKS) + 1); // Add the same enchantment but with level increase of +1
                                    }
                                }
                            } 
                        }
                                //they get healed
                                evt.getPlayer().sendMessage(ChatColor.GREEN + "Your tool has 1 more level of fortune!");
                                //message sent when enchanted
                        }
                }
                }
 
 

nothing will go wrong in console and the signs wont work.

 

Code:java

 @EventHandler
public void onSignChange(SignChangeEvent e) {
if (e.getLine(0).equalsIgnoreCase("[etoken]"))
if (e.getLine(1).equalsIgnoreCase("[Fortune1]")){
e.setLine(0, "§3[etoken]");
e.setLine(1, "§3[Fortune1]");
e.setLine(2, "§3Click here with 2 etokens!");
e.setLine(3, "§3to get an extra level of fortune!");
}
}

 

Learn java first.
You have so many problems with your code, so many...
Such as:

Code:java

if(evt.getPlayer().getInventory().getType().equals(Material.RECORD_12));

Declaring an if statement and putting a semicolon in the end, so it does absolutely nothing

Code:java

if(e.getLine(0).equalsIgnoreCase("[etoken]"))
if(e.getLine(1).equalsIgnoreCase("[Fortune1]"))

Declaring 2 if statements instead of one with &&, forgetting to put a bracket in the end of an if statement so it only does the line of code after that line.

Code:java

if(evt.getPlayer().getItemInHand().getType().equals(Material.DIAMOND_PICKAXE));{
if(evt.getPlayer().getItemInHand().getType().equals(Material.GOLD_PICKAXE));{
if(evt.getPlayer().getItemInHand().getType().equals(Material.IRON_PICKAXE));{
if(evt.getPlayer().getItemInHand().getType().equals(Material.STONE_PICKAXE));{
if(evt.getPlayer().getItemInHand().getType().equals(Material.WOOD_PICKAXE));{
 
}
 
}
}
}
}

Putting a semicolon then a bracket in the end of an if statement, making TONS of if statements instead of just checking if the getType().toString().contains("PICKAXTE"), putting if statements for no reasons (you are closing them right after checking them)

Code:java

//makes sure it's an event
//they get healed

Besides that, you are making a bunch of false comments - checking the action, is not making sure it's an event, sending a player a message, does not heal them, etc. It is not a problem but it makes your code extremely messy.

Code:java

e.setLine(0, "§3[etoken]");
e.setLine(1, "§3[Fortune1]");
e.setLine(2, "§3Click here with 2 etokens!");
e.setLine(3, "§3to get an extra level of fortune!");

Also, you cant put a line that is greater than 16 characters in a sign. But that won't matter, because of you forgot a bracket up there in the if statment, so it will only set the first line ([etoken]) of the statement, and all the others - it will set them no matter what.

Code:java

package drpk;

Your package name should be:

Code:

me.drpk.<YOURPLUGINNAME>

Also, your spacing is horrible.
Conclousion: Learn Java, then learn Bukkit, then make plugins.