Raising Sea Level In A Specific Region

I have a region I would like to flood and drain over time.

I am currently going about this just as a /water <raise/lower> command until I get it working.

I can find a region by name, find its minimum and maximum vectors, convert those to xyz coords, pass these to a selection, but have been running into a wall on how to go about replacing them.

My first thought was to just pass the selection to the worldedit replace function but if there's a sleeker way of doing this I am open to suggestions.

Current Code:

Code:java

public void execute(CommandSender sender, String[] args) throws CommandException {
 
        if (!sender.hasPermission("RisePVP.WaterLevel"))
            sender.sendMessage(Msgs.Error_Misc_No_Permission.getString());
 
        if (args.length != 1)
        {
            if (args[1].equalsIgnoreCase("Raise"))
            {
 
                Player p = (Player) sender;
                World world = p.getWorld();  //Need to be able to get this WITHOUT a sender or player.
                RegionManager rm = WGBukkit.getRegionManager(p.getWorld());
                sender.sendMessage("Raising Water Level +1");  //All sender.sendMessage's are debug code
 
                ProtectedRegion region = rm.getRegion("rise_arena");
                BlockVector ptmin = region.getMinimumPoint();
                BlockVector ptmax = region.getMaximumPoint();
                int ptminX = ptmin.getBlockX(); //Find The First Point
                int ptminY = ptmin.getBlockY();
                int ptminZ = ptmin.getBlockZ();
 
                int ptmaxX = ptmax.getBlockX(); //Find the other point of the region
                int ptmaxY = ptmax.getBlockY(); // Y is the height of the thing for some silly reason
                int ptmaxZ = ptmax.getBlockZ();
                int ptnewminX = 0;
                int ptnewmaxX = 0;
                int ptnewminZ = 0;
                int ptnewmaxZ = 0;
 
                if(ptminX < ptmaxX)  //Step the selection in 1 block (to not take out our wall)
                {
                    ptnewminX = ptminX + 1;  //Step the min X coord up by 1
                    ptnewmaxX = ptmaxX - 1; // Step the max X coord down by 1
                }
                if(ptminZ < ptmaxZ) //Step the selection in 1 block (to not take out our wall)
                {
                    ptnewminZ = ptminZ + 1; //Step the min Z coord up by 1
                    ptnewmaxZ = ptmaxZ - 1; // Step the max Z coord down by 1
                }
                sender.sendMessage("Found Region:  New min vector -"+ ptnewminX + "X " + ptminY + "Y " + ptnewminZ + "Z");
                sender.sendMessage("Found Region:  New Max Vector -"+ ptnewmaxX + "X " + ptmaxY + "Y " + ptnewmaxZ + "Z");
                if (ptmaxY > ptminY)
                {
                    sender.sendMessage("Max Y is Greater than Min Y so Min Y is lowest point.");
                    RegionFunction rf;  //still haven't figured out what to do with this
 
                    Block faceOrigin = world.getBlockAt(ptnewminX, ptminY+1, ptnewminZ);
 
                    boolean foundAir = false;
                    while(!foundAir)
                    {
                        faceOrigin = world.getBlockAt(ptnewminX, ptminY+1, ptnewminZ);
 
 
                        if ((faceOrigin.getType() == Material.WATER || faceOrigin.getType() == Material.STATIONARY_WATER))  //this should just increment for any block except air (NOT JUST WATER)
                        {
                            sender.sendMessage("Target block IS a water block! increment Y");
                            ptminY = ptminY + 1;
                        } else if(faceOrigin.getType() == Material.AIR)
                                {
                                    sender.sendMessage("Found air block at Ypos:" + ptminY);
                                    foundAir = true;
                                } 
                       //Add a check to make sure Y cant go over 255
                    }
                    org.bukkit.Location l = faceOrigin.getLocation();
                    p.teleport(l);  //teleport me to the location (more debug code)
                    //We should have valid new coordinates need to replace in the region i suppose.
                    Vector pos1 = new Vector(ptnewminX, ptminY, ptnewminZ);
                    Vector pos2 = new Vector(ptnewmaxX, ptminY, ptnewmaxZ);
                    final CuboidRegionSelector selector;
 
                    selector = new CuboidRegionSelector();
 
                    selector.selectPrimary(pos1);
                    selector.selectSecondary(pos2);
                    int area = selector.getArea();
 
                    sender.sendMessage("Area of selected area is: "+area);
//                    session.setRegionSelector(world, selector);
 
 
 
                } else {
                    sender.sendMessage("Min Y is Greater than Max Y so Max Y is lowest point.");
                }
 
 
 
            }
            else if (args[1].equalsIgnoreCase("Lower"))
            {
                sender.sendMessage("Lowering Water Level -1");
 
            }
            else
                sender.sendMessage("Syntax:  /WaterLevel <raise/lower>");
 
        }
        else
            sender.sendMessage("Syntax:  /WaterLevel <raise/lower>");
 
    }

Any ideas on where to go from here?

 

Well, can't you just...loop through the blocks and set them?

Also, don't cast the sender to a player before actually checking if the sender is a player.

 

Thanks for the reply,

Yes, that is probably an option I suppose what I need to know is is there a way to get a block list (like via the min and max points or coords) like I did with the area.

I feel like if I had a way to iterate through a dynamic block list this would be pretty simple however I haven't figured out how to get a list of blocks from two sets of coords or vectors

As for casting the sender to player this won't actually be a player command when it's all said and done so I will need to get the player out of there anyways. It's only there to get the world because I haven't figured out how to get that from the sender yet.

 

Loop through the numbers and use world.getBlockAt().

 

Okay, Sometimes it seems like it just takes someone to say it to figure out how to go about it. What I ended up doing was looping through the Z blocks, changing the air to water then moving up on the X axis +1 and doing it again until I had covered the entire region.. This seems to happen quite fast on my test server but i'm wondering if I can slow down the effect.. Ideally I would like to create a 2 block high wave above the level that would wash over things / knock players back if it hits them. All efforts to *draw* this wave above the new sea level height happen too fast to actually see the wave passing by.

I've even tried leaving the blocks there until the wave is about 4 blocks deep then erasing them for more of an effect but it still happens too quickly. I assume the route I need to take to do this is a bukkit runnable. I suppose now the question is how to make the bukkit runnable run through my code of drawing the wave, then moving the wave and have it remember where it is.... Then come back some arbitrary amount of ticks and erase the old wave, draw the next block of stationary water and draw a new wave...

My current code is like this:

Code:java

 
//Loop through the X and Z coords and change the blocks...
Block b = null;
int oldx = ptnewminX;
for (int x = ptnewminX;x < ptnewmaxX;x++) //Loop through the X coords
{
for(int z = ptnewminZ; z < ptnewmaxZ; z++) //Loop through the Z coords and change the air to water
{
b= world.getBlockAt(x,ptminY,z); //we do all the Z coords then increment the X and do it again.
if(b.getType() == Material.AIR )
b.setType(Material.STATIONARY_WATER); // This one will stay behind (new sea level)
 
//Create the wave above / in front of the new sea level
b=world.getBlockAt(x,ptminY+1,z+1); //Create a block of water above the current block
if(b.getType() == Material.AIR )
b.setType(Material.STATIONARY_WATER);
b=world.getBlockAt(x,ptminY+2,z+2); //Create a second block of water above the current block
if(b.getType() == Material.AIR )
b.setType(Material.STATIONARY_WATER);
 
}
//Erase old secondary blocks before moving the wave.
 
for (int z = ptnewminZ; z < ptnewmaxZ; z++)
{
b = world.getBlockAt(x,ptminY+1,z);
if(b.getType() == Material.WATER|| b.getType() == Material.STATIONARY_WATER )
b.setType(Material.AIR);
b = world.getBlockAt(x,ptminY+2,z);
if(b.getType() == Material.WATER || b.getType() == Material.STATIONARY_WATER )
b.setType(Material.AIR);
 
}
 
}
}
 
}

Could I put this function to sleep for X ticks? Like after each time the Wave is drawn have it sleep for 20 ticks before erasing and drawing the new wave? I don't want to make it sleep for 20 ticks inside the main plugin as to not shut everything down until the loops complete.

Or would it be better to write the X/Y/Z position's somewhere and put this inside a bukkit runnable that would read the position and pick up where the function left off?