Solved /list? - Listing all online players

Hey everyone, I know this seems like a stupid question, but I've been trying for awhile now, and I can't seem to get a /list command working! The command executes and displays a message, but it displays it twice, one for the 2 online players, here's my code:

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
if(cmd.getName().equalsIgnoreCase("list")){
Player p = (Player)sender;
for (Player list : Bukkit.getOnlinePlayers()) {
p.sendMessage(ChatColor.GOLD + "Currently Online Players: " + "" + Bukkit.getServer().getOnlinePlayers().length + "/120");
p.sendMessage(ChatColor.GREEN + "" + list.getDisplayName());

Any idea on how to go about fixing this?

 

This:

Code:

p.sendMessage(ChatColor.GOLD + "Currently Online Players: " + "" + Bukkit.getServer().getOnlinePlayers().length + "/120");

Will display for whatever number of online players there are on the server. To fix your problem, simply throw that somewhere above your loop.
Such as:

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
if(cmd.getName().equalsIgnoreCase("list")){
Player p = (Player)sender;
p.sendMessage(ChatColor.GOLD + "Currently Online Players: " + "" + Bukkit.getServer().getOnlinePlayers().length + "/120");
for (Player list : Bukkit.getOnlinePlayers()) {
p.sendMessage(ChatColor.GREEN + "" + list.getDisplayName());

 

hanahouhanah Ty! Now, there's on last problem, for every new player online, it puts the next name on another line. Ex:
Currently Online Players: 2/120
Hydrations
friend12
superguy
randomguy

 

My tired brain is telling me to just put the list of players into an arraylist and have the list be sent to the player. Otherwise... Not sure; sorry.

 

hanahouhanah Here's what it looks like: http://gyazo.com/27392651a47e3089d8394271a1fcbcc5

Array list:

Code:java

public ArrayList<String> blist = new ArrayList<String>();
 

Command:

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
if(cmd.getName().equalsIgnoreCase("list")){
Player p = (Player)sender;
p.sendMessage(ChatColor.GOLD + "Currently Online Players: " + "" + Bukkit.getServer().getOnlinePlayers().length + "/120");
for (Player blist : Bukkit.getOnlinePlayers()) {
p.sendMessage(ChatColor.GREEN + "" + blist.getName());
 
}
 
}
return false;

I want them to both be on the same line, any ideas?

 

Use a StringBuilder to easily put commas into the list, it's actually really easy.

 

You aren't adding the players to your arraylist.
Instead of your loop, do:
blist.add(Bukkit.getOnlinePlayers());
p.sendMessage(ChatColor.GREEN + "" + blist);
There's a better way to do this, but I'm not sure how. :L

 

hanahouhanah You can't add Bukkit.getOnlinePlayers() into an array list.

EDIT: Still doesn't fix the main thing i'm trying to fix, which is the string-per-line that I don't want.

 

Code:java

            StringBuilder str = new StringBuilder();
            for(Player ps : Bukkit.getOnlinePlayers()){
                if(str.length() > 0){
                    str.append(", ");
                }
                str.append("§6" + ps.getName() + "§7");
            }
            s.sendMessage(str.toString()); // s = CommandSender

 

Max_The_Link_Fan

PHP:

blist.addAll(Bukkit.getServer().getOnlinePlayers());

SringBuilder sb = new StringBuilder();
for(Player p : Bukkit.getServer().getOnlinePlayers()) {
    sb.append(p.getName()).append(", ");
}

Edit: kreashenz D:

 

Works now! Thanks to everyone who helped!

kreashenz Is there a way to set the color of a player's name to ___ if their op?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Max_The_Link_Fan
Put this in your loop:

PHP:

if(ps.isOp) {
    // append the name with the color
    continue;
}
// everything else

 

xTrollxDudex This is what I've got, it's not working. (Probs an easy mistake, I'm really tired right now)

Code:java

StringBuilder str = new StringBuilder();
            for(Player ps : Bukkit.getOnlinePlayers()){
                if(str.length() > 0){
                    str.append(", ");
                }
                if(ps.isOp()) {
                    str.append("§9" + ps.getName() + "§7");
                } else {
                str.append("§a" + ps.getName() + "§7");
 
                }
            }
            p.sendMessage(str.toString());

 

Max_The_Link_Fan
What isn't working?

 

Nevermind! IT was working, I'm stupid. :3 (Told ya im tired xD)

 

hanahouhanah Or do it this way:

Code:java

String list;
 
int count = 0;
 
for (Player p: Bukkit.getOnlinePlayers()) {
count++;
 
list += p.getName() + ", ";
}

In my mind, simpler and better then a string builder

 

JPG2000 Read the first post on page 5.
http://forums.bukkit.org/threads/common-mistakes.100544/page-5