Invalid AssignmentOperator?

Hello, I am getting this error: Syntax error on token "<", invalid AssignmentOperator Can someone please help?

Code:java

int j,i;
    for (Iterator<Player> localIterator = Players.iterator(); localIterator.hasNext(); i < j){
      Player p = (Player)localIterator.next();
      Player[] arrayOfPlayer;
      j = (arrayOfPlayer = Bukkit.getOnlinePlayers()).length; i = 0; continue; Player pl = arrayOfPlayer[i];
      p.showPlayer(pl);
 
      i++;
    }[/i]

 

The 3rd argument in a for loop should be something that is executed each loop, most likely i++. What you've got there now, i < j, is a boolean expression, so there's no point doing it each loop because there's nothing there to do. I assume what you wanted is for i<j to be part of the condition for it to continue, which is the second argument.

 

So what do you suggest i do, adam753 ?

 

It depends, what are you trying to achieve?

 

adam753 , Ok so im making a plugin that when you right click with a clock, everyone vanishes

 

localIterator.hasNext() && i <j;

 

So you're trying to go through every player stored in a list called Players, right? Here's a much easier way to iterate over a list than using that iterator nonsense:

Code:

for(Player p : Players) {
 
}

 

ok lemme try that

adam753, Now i get an unreachable code error

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Unreachable code where? Can I see all the code in this method, please?

 

Code:java

public void onDisable()
{
int j;
int i;
for (Iterator<Player> localIterator = Players.iterator(); localIterator.hasNext(); i < j){
Player p = (Player)localIterator.next();
Player[] arrayOfPlayer;
j = (arrayOfPlayer = Bukkit.getOnlinePlayers()).length; i = 0; continue; Player pl = arrayOfPlayer[I];[/I]
[I] p.showPlayer(pl);[/I]
 
[I] i++;[/I]
[I] }[/I]
 
[I] Players.clear();[/I]
[I] Antispam.clear();[/I]
[I] }[/I]

adam753, There's my code

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Isn't this exactly the same as at the start of the thread? Start by replacing line 5 with:

Code:

for(Player p : Players) {

And where is the unreachable code?

 

Now i get the unreachable code error

Code:java

  public void onDisable()
  {
      int j;
      int i;
    for (Player p : Players){
          Player[] arrayOfPlayer;
          j = (arrayOfPlayer = Bukkit.getOnlinePlayers()).length; i = 0; continue; Player pl = arrayOfPlayer[i];
          p.showPlayer(pl);
 
          i++;
    }[/i]

 

Code:

j = (arrayOfPlayer = Bukkit.getOnlinePlayers()).length; i = 0; continue; Player pl = arrayOfPlayer[i];

Okay.. Why do you have "continue" in there? You're doing several lines on one line there, and one of those things is "continue", which makes the loop stop this iteration and go onto the next one, so anything after "continue" won't be done. Why are you doing so many things on one line?

 

ok that helps me, adam753, but now do i just do an if statement to keep the loop going?

 

What do you mean? The loop will keep going by itself. The code inside the loop will be run for each player in the list, and each time the variable "p" will be the next player in the list.

 

adam753, ok but now it says int j is never used

 

You're trying to make every player visible to every other player, right? You would need two loops. An outside one to loop through every player, and an inside one to show every player to them.

Code:

for(Player p1 : bukkit.getOnlinePlayers()) {
    for(Player p2 : bukkit.getOnlinePlayers()) {
        p1.showPlayer(p2);
    }
}

It seems like you don't understand the code you've given me. It looks like you're new to Java, which is understandable, but you should really stick to simple steps before you go trying to write what you showed me earlier.