Player Kill Player Event

For my plugin I need an event the detects when a player kills another player. I have

Code:

    @EventHandler
    public void onEntityDamagedByEntity(EntityDamageByEntityEvent e) {
        if (e.getDamager() instanceof Player) {
            Player killer = (Player) e.getDamager();
            if (e.getEntityType() == EntityType.PLAYER) {
                Player killed = (Player) e.getEntity();
                if (killed.isDead() || killed.getHealth() <= 0) {
                    log.info("A player killed another player"); // never reaches here
                }
            }
        }
    }

does anyone know why it doesn't work?

Thanks

 

What doesn't work? do you get an error, or does it just not show anything? If it doesn't show anything, you might want to display a message at every level to understand where it screws up

 

No error, just nothing shows up. I'll try adding more messages

 

This for the event Listener

Code:java

 @EventHandler
public void onKill(PlayerDeathEvent e)
{
String killed = e.getEntity().getName();
String killer = e.getEntity().getKiller().getName();
e.setDeathMessage(ChatColor.RED + killed + " has been slain by " + killer);
}

And be sure you have register event onEnable() with :

Code:java

getServer().getPluginManager().registerEvents(this, this);

 

Shouldn't you use EntityDeathEvent? As I recall, the PlayerDeathEvent doesn't work...

 

PlayerDeathEvent Work perfectly on bukkit 1.2.5-R1.0

 

thanks monowii I didn't know playerdeathevent worked

 

Good to know

 

Here is the code I ended up using the the playerdeathevent

Code:

        if (e.getEntity().getKiller() != null) {
            String killedName = e.getEntity().getName();
            if (tributes.containsKey(killedName)) {
                String killerName = e.getEntity().getKiller().getName();
                log.info(ChatColor.RED + killedName + " has been slain by " + killerName);
            }
        }

 

Just to explain why your original code didn't work, Events fire before the event happens. This allows plugins to modify the event to their liking, so technically, if a player is dealt fatal damage at this point, your event is firing before the damage is applied, and the player is not dead yet ^ ^

 

question, is there a way i could extend on this playerdeathevent thing to somehow include what the player was killed with? is there an event extention for that?

 

Try adding

Code:

+ killerName().getInventory().getItemInHand()); 

To the message.
So for example:

Code:

Bukkit.getServer().broadcastMessage(killedName + " has been slain by " + killerName + " with " + killerName().getInventory().getItemInHand()));

 

an idea i had expanded on was to log all of the deaths on my server, in detail, of how it happened.
It really helps when we have people who come and murder animal farms on our server. Check it out!